2021-05-08 17:06:13

by Saurav Girepunje

[permalink] [raw]
Subject: [PATCH 0/2] Remove unused variable in musb_host.c

This series contains 2 patches to remove unused local variable
from function musb_tx_dma_set_mode_cppi_tusb and function
musb_tx_dma_set_mode_mentor in musb_host.c file.

Saurav Girepunje (2):
usb: musb: Remove unused local variable dma, urb, offset
usb: musb: Remove unused function argument dma, qh, offset, length

drivers/usb/musb/musb_host.c | 18 ++++++------------
1 file changed, 6 insertions(+), 12 deletions(-)

--
2.25.1


2021-05-08 17:06:47

by Saurav Girepunje

[permalink] [raw]
Subject: [PATCH 1/2] usb: musb: Remove unused local variable dma, urb, offset

Remove unused function argument struct dma_controller *dma,
struct urb *urb and u32 offset from musb_tx_dma_set_mode_mentor.

Signed-off-by: Saurav Girepunje <[email protected]>
---
drivers/usb/musb/musb_host.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
index 8b7d22a0c0fb..14d9b366e605 100644
--- a/drivers/usb/musb/musb_host.c
+++ b/drivers/usb/musb/musb_host.c
@@ -563,10 +563,9 @@ musb_rx_reinit(struct musb *musb, struct musb_qh *qh, u8 epnum)
ep->rx_reinit = 0;
}

-static void musb_tx_dma_set_mode_mentor(struct dma_controller *dma,
- struct musb_hw_ep *hw_ep, struct musb_qh *qh,
- struct urb *urb, u32 offset,
- u32 *length, u8 *mode)
+static void musb_tx_dma_set_mode_mentor(struct musb_hw_ep *hw_ep,
+ struct musb_qh *qh,
+ u32 *length, u8 *mode)
{
struct dma_channel *channel = hw_ep->tx_channel;
void __iomem *epio = hw_ep->regs;
@@ -630,7 +629,7 @@ static bool musb_tx_dma_program(struct dma_controller *dma,
u8 mode;

if (musb_dma_inventra(hw_ep->musb) || musb_dma_ux500(hw_ep->musb))
- musb_tx_dma_set_mode_mentor(dma, hw_ep, qh, urb, offset,
+ musb_tx_dma_set_mode_mentor(hw_ep, qh,
&length, &mode);
else if (is_cppi_enabled(hw_ep->musb) || tusb_dma_omap(hw_ep->musb))
musb_tx_dma_set_mode_cppi_tusb(dma, hw_ep, qh, urb, offset,
--
2.25.1

2021-05-08 17:08:32

by Saurav Girepunje

[permalink] [raw]
Subject: [PATCH 2/2] usb: musb: Remove unused function argument dma, qh, offset, length

Remove unused function argument dma, qh, offset, length from
musb_tx_dma_set_mode_cppi_tusb() in musb_host.c

Signed-off-by: Saurav Girepunje <[email protected]>
---
drivers/usb/musb/musb_host.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
index 14d9b366e605..a4c185747358 100644
--- a/drivers/usb/musb/musb_host.c
+++ b/drivers/usb/musb/musb_host.c
@@ -601,12 +601,8 @@ static void musb_tx_dma_set_mode_mentor(struct musb_hw_ep *hw_ep,
musb_writew(epio, MUSB_TXCSR, csr);
}

-static void musb_tx_dma_set_mode_cppi_tusb(struct dma_controller *dma,
- struct musb_hw_ep *hw_ep,
- struct musb_qh *qh,
+static void musb_tx_dma_set_mode_cppi_tusb(struct musb_hw_ep *hw_ep,
struct urb *urb,
- u32 offset,
- u32 *length,
u8 *mode)
{
struct dma_channel *channel = hw_ep->tx_channel;
@@ -632,8 +628,7 @@ static bool musb_tx_dma_program(struct dma_controller *dma,
musb_tx_dma_set_mode_mentor(hw_ep, qh,
&length, &mode);
else if (is_cppi_enabled(hw_ep->musb) || tusb_dma_omap(hw_ep->musb))
- musb_tx_dma_set_mode_cppi_tusb(dma, hw_ep, qh, urb, offset,
- &length, &mode);
+ musb_tx_dma_set_mode_cppi_tusb(hw_ep, urb, &mode);
else
return false;

--
2.25.1