2021-05-09 09:13:17

by Mike Rapoport

Subject: [PATCH 0/2] openrisc: mm/init.c: fix compilation warnings

From: Mike Rapoport <[email protected]>

Hi,

Kbuld test bot reported an unused in map_ram() and while on it I've found
another compilation warning about unused variable in paging_init().

Here are the fixes for both.
The patches are vs 5.12.

Mike Rapoport (2):
openrisc: mm/init.c: remove unused memblock_region variable in map_ram()
openrisc: mm/init.c: remove unused variable 'end' in paging_init()

arch/openrisc/mm/init.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)


base-commit: 9f4ad9e425a1d3b6a34617b8ea226d56a119a717
--
2.28.0

2021-05-09 09:14:08

by Mike Rapoport

Subject: [PATCH 1/2] openrisc: mm/init.c: remove unused memblock_region variable in map_ram()

From: Mike Rapoport <[email protected]>

Kernel test robot reports:

cppcheck possible warnings: (new ones prefixed by >>, may not real problems)

>> arch/openrisc/mm/init.c:125:10: warning: Uninitialized variable: region [uninitvar]
region->base, region->base + region->size);
^

Replace usage of memblock_region fields with 'start' and 'end' variables
that are initialized in for_each_mem_range() and remove the declaration of
region.

Fixes: b10d6bca8720 ("arch, drivers: replace for_each_membock() with for_each_mem_range()")
Reported-by: kernel test robot <[email protected]>
Signed-off-by: Mike Rapoport <[email protected]>
---
arch/openrisc/mm/init.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/openrisc/mm/init.c b/arch/openrisc/mm/init.c
index bf9b2310fc93..f3fa02b8838a 100644
--- a/arch/openrisc/mm/init.c
+++ b/arch/openrisc/mm/init.c
@@ -75,7 +75,6 @@ static void __init map_ram(void)
/* These mark extents of read-only kernel pages...
* ...from vmlinux.lds.S
*/
- struct memblock_region *region;

v = PAGE_OFFSET;

@@ -121,7 +120,7 @@ static void __init map_ram(void)
}

printk(KERN_INFO "%s: Memory: 0x%x-0x%x\n", __func__,
- region->base, region->base + region->size);
+ start, end);
}
}

--
2.28.0

2021-05-09 21:20:29

by Stafford Horne

Subject: Re: [PATCH 1/2] openrisc: mm/init.c: remove unused memblock_region variable in map_ram()

On Sun, May 09, 2021 at 12:11:02PM +0300, Mike Rapoport wrote:
> From: Mike Rapoport <[email protected]>
>
> Kernel test robot reports:
>
> cppcheck possible warnings: (new ones prefixed by >>, may not real problems)
>
> >> arch/openrisc/mm/init.c:125:10: warning: Uninitialized variable: region [uninitvar]
> region->base, region->base + region->size);
> ^
>
> Replace usage of memblock_region fields with 'start' and 'end' variables
> that are initialized in for_each_mem_range() and remove the declaration of
> region.
>
> Fixes: b10d6bca8720 ("arch, drivers: replace for_each_membock() with for_each_mem_range()")
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Mike Rapoport <[email protected]>
> ---
> arch/openrisc/mm/init.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/openrisc/mm/init.c b/arch/openrisc/mm/init.c
> index bf9b2310fc93..f3fa02b8838a 100644
> --- a/arch/openrisc/mm/init.c
> +++ b/arch/openrisc/mm/init.c
> @@ -75,7 +75,6 @@ static void __init map_ram(void)
> /* These mark extents of read-only kernel pages...
> * ...from vmlinux.lds.S
> */
> - struct memblock_region *region;
>
> v = PAGE_OFFSET;
>
> @@ -121,7 +120,7 @@ static void __init map_ram(void)
> }
>
> printk(KERN_INFO "%s: Memory: 0x%x-0x%x\n", __func__,
> - region->base, region->base + region->size);
> + start, end);
> }
> }

Thanks I will queue this.

-Stafford