2021-05-09 13:46:30

by Rajat Asthana

[permalink] [raw]
Subject: [PATCH] drm: Declare drm_send_event_helper static.

From: Rajat <[email protected]>

Declare drm_send_event_helper as static to fix sparse warning:

> warning: symbol 'drm_send_event_helper' was not declared.
> Should it be static?

Signed-off-by: Rajat <[email protected]>
---
drivers/gpu/drm/drm_file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c
index 7efbccffc2ea..17f38d873972 100644
--- a/drivers/gpu/drm/drm_file.c
+++ b/drivers/gpu/drm/drm_file.c
@@ -786,7 +786,7 @@ EXPORT_SYMBOL(drm_event_cancel_free);
* The timestamp variant of dma_fence_signal is used when the caller
* sends a valid timestamp.
*/
-void drm_send_event_helper(struct drm_device *dev,
+static void drm_send_event_helper(struct drm_device *dev,
struct drm_pending_event *e, ktime_t timestamp)
{
assert_spin_locked(&dev->event_lock);
--
2.31.1


2021-05-10 16:03:22

by Maxime Ripard

[permalink] [raw]
Subject: Re: [PATCH] drm: Declare drm_send_event_helper static.

Hi,

On Sun, May 09, 2021 at 07:12:52PM +0530, Rajat Asthana wrote:
> From: Rajat <[email protected]>
>
> Declare drm_send_event_helper as static to fix sparse warning:
>
> > warning: symbol 'drm_send_event_helper' was not declared.
> > Should it be static?
>
> Signed-off-by: Rajat <[email protected]>

Both the Author and Signed-off-by should have your full name

Thanks!
Maxime


Attachments:
(No filename) (408.00 B)
signature.asc (235.00 B)
Download all attachments