2021-05-10 03:10:06

by Jiabing Wan

[permalink] [raw]
Subject: [PATCH] m68k: dma: remove unnecessary include of asm/cacheflush.h

In commit ca15ca406f660 ("mm: remove unneeded includes of
<asm/pgalloc.h>"), asm/cacheflush.h independent on the MACRO
was included at line 18. The include here is unnecessary. Remove it.

Signed-off-by: Wan Jiabing <[email protected]>
---
arch/m68k/kernel/dma.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/arch/m68k/kernel/dma.c b/arch/m68k/kernel/dma.c
index 1c1b875fadc1..2e192a5df949 100644
--- a/arch/m68k/kernel/dma.c
+++ b/arch/m68k/kernel/dma.c
@@ -34,9 +34,6 @@ pgprot_t pgprot_dmacoherent(pgprot_t prot)
return prot;
}
#else
-
-#include <asm/cacheflush.h>
-
void *arch_dma_alloc(struct device *dev, size_t size, dma_addr_t *dma_handle,
gfp_t gfp, unsigned long attrs)
{
--
2.20.1


2021-05-10 07:08:50

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH] m68k: dma: remove unnecessary include of asm/cacheflush.h

On Mon, May 10, 2021 at 5:08 AM Wan Jiabing <[email protected]> wrote:
> In commit ca15ca406f660 ("mm: remove unneeded includes of
> <asm/pgalloc.h>"), asm/cacheflush.h independent on the MACRO
> was included at line 18. The include here is unnecessary. Remove it.
>
> Signed-off-by: Wan Jiabing <[email protected]>

Reviewed-by: Geert Uytterhoeven <[email protected]>
i.e. will queue in the m68k for-v5.14 branch.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds