2021-05-10 13:06:31

by Fabio Aiuto

Subject: [PATCH 2/2] staging: rtl8723bs: move comments to silence 'line too long' warning

move comments to fix the following post commit hook
checkpatch warnings:

WARNING: line length of 110 exceeds 100 columns
115: FILE: drivers/staging/rtl8723bs/core/rtw_security.c:510:
+ *((__le32 *)crc)
= ~crc32_le(~0, payload, length);/* modified by Amy*/

WARNING: line length of 110 exceeds 100 columns
124: FILE: drivers/staging/rtl8723bs/core/rtw_security.c:518:
+ *((__le32 *)crc)
= ~crc32_le(~0, payload, length);/* modified by Amy*/

Signed-off-by: Fabio Aiuto <[email protected]>
---
drivers/staging/rtl8723bs/core/rtw_security.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/staging/rtl8723bs/core/rtw_security.c
index bee1b2e2504e..4d0a86b69f41 100644
--- a/drivers/staging/rtl8723bs/core/rtw_security.c
+++ b/drivers/staging/rtl8723bs/core/rtw_security.c
@@ -507,7 +507,8 @@ u32 rtw_tkip_encrypt(struct adapter *padapter, u8 *pxmitframe)

if ((curfragnum+1) == pattrib->nr_frags) { /* 4 the last fragment */
length = pattrib->last_txcmdsz-pattrib->hdrlen-pattrib->iv_len-pattrib->icv_len;
- *((__le32 *)crc) = ~crc32_le(~0, payload, length);/* modified by Amy*/
+ /* modified by Amy*/
+ *((__le32 *)crc) = ~crc32_le(~0, payload, length);

arc4_setkey(&mycontext, rc4key, 16);
arc4_crypt(&mycontext, payload, payload, length);
@@ -515,7 +516,9 @@ u32 rtw_tkip_encrypt(struct adapter *padapter, u8 *pxmitframe)

} else {
length = pxmitpriv->frag_len-pattrib->hdrlen-pattrib->iv_len-pattrib->icv_len;
- *((__le32 *)crc) = ~crc32_le(~0, payload, length);/* modified by Amy*/
+ /* modified by Amy*/
+ *((__le32 *)crc) = ~crc32_le(~0, payload, length);
+
arc4_setkey(&mycontext, rc4key, 16);
arc4_crypt(&mycontext, payload, payload, length);
arc4_crypt(&mycontext, payload + length, crc, 4);
--
2.20.1

2021-05-10 13:15:37

by Dan Carpenter

Subject: Re: [PATCH 2/2] staging: rtl8723bs: move comments to silence 'line too long' warning

On Mon, May 10, 2021 at 02:46:19PM +0200, Fabio Aiuto wrote:
> move comments to fix the following post commit hook
> checkpatch warnings:
>
> WARNING: line length of 110 exceeds 100 columns
> 115: FILE: drivers/staging/rtl8723bs/core/rtw_security.c:510:
> + *((__le32 *)crc)
> = ~crc32_le(~0, payload, length);/* modified by Amy*/

Please delete the Amy comments. :P

regards,
dan carpenter

2021-05-10 13:16:31

by Fabio Aiuto

Subject: Re: [PATCH 2/2] staging: rtl8723bs: move comments to silence 'line too long' warning

On Mon, May 10, 2021 at 04:00:19PM +0300, Dan Carpenter wrote:
> On Mon, May 10, 2021 at 02:46:19PM +0200, Fabio Aiuto wrote:
> > move comments to fix the following post commit hook
> > checkpatch warnings:
> >
> > WARNING: line length of 110 exceeds 100 columns
> > 115: FILE: drivers/staging/rtl8723bs/core/rtw_security.c:510:
> > + *((__le32 *)crc)
> > = ~crc32_le(~0, payload, length);/* modified by Amy*/
>
> Please delete the Amy comments. :P

ok, will fix and submit a v2 :)

>
> regards,
> dan carpenter
>

thank you,

fabio