2021-05-10 13:27:08

by Rajat Asthana

Subject: [PATCH v2] drm: Declare drm_send_event_helper static.

Declare drm_send_event_helper as static to fix sparse warning:

> warning: symbol 'drm_send_event_helper' was not declared.
> Should it be static?

Signed-off-by: Rajat Asthana <[email protected]>
---
Changes in v2:
Provide full name in Author and Signed-off.

drivers/gpu/drm/drm_file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c
index 7efbccffc2ea..17f38d873972 100644
--- a/drivers/gpu/drm/drm_file.c
+++ b/drivers/gpu/drm/drm_file.c
@@ -786,7 +786,7 @@ EXPORT_SYMBOL(drm_event_cancel_free);
* The timestamp variant of dma_fence_signal is used when the caller
* sends a valid timestamp.
*/
-void drm_send_event_helper(struct drm_device *dev,
+static void drm_send_event_helper(struct drm_device *dev,
struct drm_pending_event *e, ktime_t timestamp)
{
assert_spin_locked(&dev->event_lock);
--
2.31.1

2021-05-10 22:37:25

by Guenter Roeck

Subject: Re: [PATCH v2] drm: Declare drm_send_event_helper static.

On Mon, May 10, 2021 at 06:46:16PM +0530, Rajat Asthana wrote:
> Declare drm_send_event_helper as static to fix sparse warning:
>
> > warning: symbol 'drm_send_event_helper' was not declared.
> > Should it be static?
>
> Signed-off-by: Rajat Asthana <[email protected]>
> ---
> Changes in v2:
> Provide full name in Author and Signed-off.
>

Turns out a variant of this patch [1] has already been accepted.

Guenter

---
[1] https://patchwork.kernel.org/project/dri-devel/patch/[email protected]/