2021-05-10 22:43:00

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: Fixes tag needs some work in the amdgpu tree

Hi all,

In commit

0b62b6ed6959 ("drm/amd/display: Initialize attribute for hdcp_srm sysfs file")

Fixes tag

Fixes: a193ed2094ba ("drm/amd/display: Add sysfs interface for set/get srm")

has these problem(s):

- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'

Maybe you meant

Fixes: 9037246bb2da ("drm/amd/display: Add sysfs interface for set/get srm")

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2021-05-10 23:09:57

by David Ward

[permalink] [raw]
Subject: Re: linux-next: Fixes tag needs some work in the amdgpu tree

On 5/10/21 6:42 PM, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> 0b62b6ed6959 ("drm/amd/display: Initialize attribute for hdcp_srm sysfs file")
>
> Fixes tag
>
> Fixes: a193ed2094ba ("drm/amd/display: Add sysfs interface for set/get srm")
>
> has these problem(s):
>
> - Subject does not match target commit subject
> Just use
> git log -1 --format='Fixes: %h ("%s")'
>
> Maybe you meant
>
> Fixes: 9037246bb2da ("drm/amd/display: Add sysfs interface for set/get srm")
>
My apologies. The correct hash is in fact 9037246bb2da. (Commit
a193ed2094ba introduced HDCP handling in amdgpu_pm, but did not include
the sysfs file.) It seems I inadvertently copied the wrong hash when
preparing the commit message.

Please let me know if I need to resubmit this patch.

Thank you,

David


2021-05-11 13:44:23

by Alex Deucher

[permalink] [raw]
Subject: Re: linux-next: Fixes tag needs some work in the amdgpu tree

I'll fix it up.

Alex

On Mon, May 10, 2021 at 7:08 PM David Ward <[email protected]> wrote:
>
> On 5/10/21 6:42 PM, Stephen Rothwell wrote:
> > Hi all,
> >
> > In commit
> >
> > 0b62b6ed6959 ("drm/amd/display: Initialize attribute for hdcp_srm sysfs file")
> >
> > Fixes tag
> >
> > Fixes: a193ed2094ba ("drm/amd/display: Add sysfs interface for set/get srm")
> >
> > has these problem(s):
> >
> > - Subject does not match target commit subject
> > Just use
> > git log -1 --format='Fixes: %h ("%s")'
> >
> > Maybe you meant
> >
> > Fixes: 9037246bb2da ("drm/amd/display: Add sysfs interface for set/get srm")
> >
> My apologies. The correct hash is in fact 9037246bb2da. (Commit
> a193ed2094ba introduced HDCP handling in amdgpu_pm, but did not include
> the sysfs file.) It seems I inadvertently copied the wrong hash when
> preparing the commit message.
>
> Please let me know if I need to resubmit this patch.
>
> Thank you,
>
> David
>
>