2021-05-11 07:53:04

by Jisheng Zhang

[permalink] [raw]
Subject: [PATCH] clocksource/drivers/arm_arch_timer: Remove arch_timer_rate1

This variable is added by my mistake, it's not used at all.

Fixes: e2bf384d4329 ("clocksource/drivers/arm_arch_timer: Add __ro_after_init and __init")
Signed-off-by: Jisheng Zhang <[email protected]>
Reported-by: Hulk Robot <[email protected]>
---

drivers/clocksource/arm_arch_timer.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
index fe1a82627d57..89a9e0524555 100644
--- a/drivers/clocksource/arm_arch_timer.c
+++ b/drivers/clocksource/arm_arch_timer.c
@@ -64,7 +64,6 @@ struct arch_timer {
#define to_arch_timer(e) container_of(e, struct arch_timer, evt)

static u32 arch_timer_rate __ro_after_init;
-u32 arch_timer_rate1 __ro_after_init;
static int arch_timer_ppi[ARCH_TIMER_MAX_TIMER_PPI] __ro_after_init;

static const char *arch_timer_ppi_names[ARCH_TIMER_MAX_TIMER_PPI] = {
--
2.31.0


2021-05-11 08:37:59

by Marc Zyngier

[permalink] [raw]
Subject: Re: [PATCH] clocksource/drivers/arm_arch_timer: Remove arch_timer_rate1

On Tue, 11 May 2021 08:48:56 +0100,
Jisheng Zhang <[email protected]> wrote:
>
> This variable is added by my mistake, it's not used at all.
>
> Fixes: e2bf384d4329 ("clocksource/drivers/arm_arch_timer: Add __ro_after_init and __init")
> Signed-off-by: Jisheng Zhang <[email protected]>
> Reported-by: Hulk Robot <[email protected]>

Acked-by: Marc Zyngier <[email protected]>

M.

--
Without deviation from the norm, progress is not possible.

Subject: [tip: timers/core] clocksource/drivers/arm_arch_timer: Remove arch_timer_rate1

The following commit has been merged into the timers/core branch of tip:

Commit-ID: 4f9f4f0f6261e4b162dfcaf91e08824a7c93da07
Gitweb: https://git.kernel.org/tip/4f9f4f0f6261e4b162dfcaf91e08824a7c93da07
Author: Jisheng Zhang <[email protected]>
AuthorDate: Tue, 11 May 2021 15:48:56 +08:00
Committer: Daniel Lezcano <[email protected]>
CommitterDate: Thu, 03 Jun 2021 22:15:12 +02:00

clocksource/drivers/arm_arch_timer: Remove arch_timer_rate1

This variable is added by my mistake, it's not used at all.

Fixes: e2bf384d4329 ("clocksource/drivers/arm_arch_timer: Add __ro_after_init and __init")
Signed-off-by: Jisheng Zhang <[email protected]>
Reported-by: Hulk Robot <[email protected]>
Acked-by: Marc Zyngier <[email protected]>
Signed-off-by: Daniel Lezcano <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
---
drivers/clocksource/arm_arch_timer.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
index fe1a826..89a9e05 100644
--- a/drivers/clocksource/arm_arch_timer.c
+++ b/drivers/clocksource/arm_arch_timer.c
@@ -64,7 +64,6 @@ struct arch_timer {
#define to_arch_timer(e) container_of(e, struct arch_timer, evt)

static u32 arch_timer_rate __ro_after_init;
-u32 arch_timer_rate1 __ro_after_init;
static int arch_timer_ppi[ARCH_TIMER_MAX_TIMER_PPI] __ro_after_init;

static const char *arch_timer_ppi_names[ARCH_TIMER_MAX_TIMER_PPI] = {