2021-05-12 09:42:22

by Chunyan Zhang

Subject: [PATCH] thermal: sprd: Add missing MODULE_DEVICE_TABLE

From: Chunyan Zhang <[email protected]>

MODULE_DEVICE_TABLE is used to extract the device information out of the
driver and builds a table when being compiled. If using this macro,
kernel can find the driver if available when the device is plugged in,
and then loads that driver and initializes the device.

Signed-off-by: Chunyan Zhang <[email protected]>
---
drivers/thermal/sprd_thermal.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/thermal/sprd_thermal.c b/drivers/thermal/sprd_thermal.c
index 3682edb2f466..fe06cccf14b3 100644
--- a/drivers/thermal/sprd_thermal.c
+++ b/drivers/thermal/sprd_thermal.c
@@ -532,6 +532,7 @@ static const struct of_device_id sprd_thermal_of_match[] = {
{ .compatible = "sprd,ums512-thermal", .data = &ums512_data },
{ },
};
+MODULE_DEVICE_TABLE(of, sprd_thermal_of_match);

static const struct dev_pm_ops sprd_thermal_pm_ops = {
SET_SYSTEM_SLEEP_PM_OPS(sprd_thm_suspend, sprd_thm_resume)
--
2.25.1

2021-06-11 09:36:27

by Daniel Lezcano

Subject: Re: [PATCH] thermal: sprd: Add missing MODULE_DEVICE_TABLE

On 12/05/2021 11:37, Chunyan Zhang wrote:
> From: Chunyan Zhang <[email protected]>
>
> MODULE_DEVICE_TABLE is used to extract the device information out of the
> driver and builds a table when being compiled. If using this macro,
> kernel can find the driver if available when the device is plugged in,
> and then loads that driver and initializes the device.
>
> Signed-off-by: Chunyan Zhang <[email protected]>

Applied, and added the Fixes tag:

Fixes: 554fdbaf19b18 ("thermal: sprd: Add Spreadtrum thermal driver
support")

> ---
> drivers/thermal/sprd_thermal.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/thermal/sprd_thermal.c b/drivers/thermal/sprd_thermal.c
> index 3682edb2f466..fe06cccf14b3 100644
> --- a/drivers/thermal/sprd_thermal.c
> +++ b/drivers/thermal/sprd_thermal.c
> @@ -532,6 +532,7 @@ static const struct of_device_id sprd_thermal_of_match[] = {
> { .compatible = "sprd,ums512-thermal", .data = &ums512_data },
> { },
> };
> +MODULE_DEVICE_TABLE(of, sprd_thermal_of_match);
>
> static const struct dev_pm_ops sprd_thermal_pm_ops = {
> SET_SYSTEM_SLEEP_PM_OPS(sprd_thm_suspend, sprd_thm_resume)
>


--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog