2021-05-12 10:03:51

by Lin Feng

Subject: [PATCH] blkdev.h: remove unused codes blk_account_rq

Last users of blk_account_rq gone with patch commit a1ce35fa49852db
("block: remove dead elevator code") and now it gets no caller, it can
be safely removed.

Signed-off-by: Lin Feng <[email protected]>
---
include/linux/blkdev.h | 5 -----
1 file changed, 5 deletions(-)

diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 1255823b2bc0..f69c75bd6d27 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -676,11 +676,6 @@ bool blk_queue_flag_test_and_set(unsigned int flag, struct request_queue *q);
extern void blk_set_pm_only(struct request_queue *q);
extern void blk_clear_pm_only(struct request_queue *q);

-static inline bool blk_account_rq(struct request *rq)
-{
- return (rq->rq_flags & RQF_STARTED) && !blk_rq_is_passthrough(rq);
-}
-
#define list_entry_rq(ptr) list_entry((ptr), struct request, queuelist)

#define rq_data_dir(rq) (op_is_write(req_op(rq)) ? WRITE : READ)
--
2.30.2

2021-05-12 13:43:59

by Jens Axboe

Subject: Re: [PATCH] blkdev.h: remove unused codes blk_account_rq

On 5/12/21 4:01 AM, Lin Feng wrote:
> Last users of blk_account_rq gone with patch commit a1ce35fa49852db
> ("block: remove dead elevator code") and now it gets no caller, it can
> be safely removed.

Applied, thanks.

--
Jens Axboe