2021-05-12 22:23:50

by Maximilian Luz

Subject: [PATCH] serial: 8250_dw: Add device HID for new AMD UART controller

Add device HID AMDI0022 to the AMD UART controller driver match table
and create a platform device for it. This controller can be found on
Microsoft Surface Laptop 4 devices and seems similar enough that we can
just copy the existing AMDI0020 entries.

Cc: <[email protected]> # 5.10+
Tested-by: Sachi King <[email protected]>
Signed-off-by: Maximilian Luz <[email protected]>
---
drivers/acpi/acpi_apd.c | 1 +
drivers/tty/serial/8250/8250_dw.c | 1 +
2 files changed, 2 insertions(+)

diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
index 0ec5b3f69112..6e02448d15d9 100644
--- a/drivers/acpi/acpi_apd.c
+++ b/drivers/acpi/acpi_apd.c
@@ -226,6 +226,7 @@ static const struct acpi_device_id acpi_apd_device_ids[] = {
{ "AMDI0010", APD_ADDR(wt_i2c_desc) },
{ "AMD0020", APD_ADDR(cz_uart_desc) },
{ "AMDI0020", APD_ADDR(cz_uart_desc) },
+ { "AMDI0022", APD_ADDR(cz_uart_desc) },
{ "AMD0030", },
{ "AMD0040", APD_ADDR(fch_misc_desc)},
{ "HYGO0010", APD_ADDR(wt_i2c_desc) },
diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
index 9e204f9b799a..a3a0154da567 100644
--- a/drivers/tty/serial/8250/8250_dw.c
+++ b/drivers/tty/serial/8250/8250_dw.c
@@ -714,6 +714,7 @@ static const struct acpi_device_id dw8250_acpi_match[] = {
{ "APMC0D08", 0},
{ "AMD0020", 0 },
{ "AMDI0020", 0 },
+ { "AMDI0022", 0 },
{ "BRCM2032", 0 },
{ "HISI0031", 0 },
{ },
--
2.31.1

2021-05-13 07:10:49

by Andy Shevchenko

Subject: Re: [PATCH] serial: 8250_dw: Add device HID for new AMD UART controller

On Thu, May 13, 2021 at 1:20 AM Maximilian Luz <[email protected]> wrote:
>
> Add device HID AMDI0022 to the AMD UART controller driver match table
> and create a platform device for it. This controller can be found on
> Microsoft Surface Laptop 4 devices and seems similar enough that we can
> just copy the existing AMDI0020 entries.

Acked-by: Andy Shevchenko <[email protected]> # for 8250_dw part

> Cc: <[email protected]> # 5.10+
> Tested-by: Sachi King <[email protected]>
> Signed-off-by: Maximilian Luz <[email protected]>
> ---
> drivers/acpi/acpi_apd.c | 1 +
> drivers/tty/serial/8250/8250_dw.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
> index 0ec5b3f69112..6e02448d15d9 100644
> --- a/drivers/acpi/acpi_apd.c
> +++ b/drivers/acpi/acpi_apd.c
> @@ -226,6 +226,7 @@ static const struct acpi_device_id acpi_apd_device_ids[] = {
> { "AMDI0010", APD_ADDR(wt_i2c_desc) },
> { "AMD0020", APD_ADDR(cz_uart_desc) },
> { "AMDI0020", APD_ADDR(cz_uart_desc) },
> + { "AMDI0022", APD_ADDR(cz_uart_desc) },
> { "AMD0030", },
> { "AMD0040", APD_ADDR(fch_misc_desc)},
> { "HYGO0010", APD_ADDR(wt_i2c_desc) },
> diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
> index 9e204f9b799a..a3a0154da567 100644
> --- a/drivers/tty/serial/8250/8250_dw.c
> +++ b/drivers/tty/serial/8250/8250_dw.c
> @@ -714,6 +714,7 @@ static const struct acpi_device_id dw8250_acpi_match[] = {
> { "APMC0D08", 0},
> { "AMD0020", 0 },
> { "AMDI0020", 0 },
> + { "AMDI0022", 0 },
> { "BRCM2032", 0 },
> { "HISI0031", 0 },
> { },
> --
> 2.31.1
>


--
With Best Regards,
Andy Shevchenko

2021-05-18 10:13:29

by Rafael J. Wysocki

Subject: Re: [PATCH] serial: 8250_dw: Add device HID for new AMD UART controller

On Thu, May 13, 2021 at 12:25 AM Maximilian Luz <[email protected]> wrote:
>
> Add device HID AMDI0022 to the AMD UART controller driver match table
> and create a platform device for it. This controller can be found on
> Microsoft Surface Laptop 4 devices and seems similar enough that we can
> just copy the existing AMDI0020 entries.
>
> Cc: <[email protected]> # 5.10+
> Tested-by: Sachi King <[email protected]>
> Signed-off-by: Maximilian Luz <[email protected]>

Acked-by: Rafael J. Wysocki <[email protected]>

or please let me know if this needs to go in through ACPI (I'm
assuming that it doesn't).

> ---
> drivers/acpi/acpi_apd.c | 1 +
> drivers/tty/serial/8250/8250_dw.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
> index 0ec5b3f69112..6e02448d15d9 100644
> --- a/drivers/acpi/acpi_apd.c
> +++ b/drivers/acpi/acpi_apd.c
> @@ -226,6 +226,7 @@ static const struct acpi_device_id acpi_apd_device_ids[] = {
> { "AMDI0010", APD_ADDR(wt_i2c_desc) },
> { "AMD0020", APD_ADDR(cz_uart_desc) },
> { "AMDI0020", APD_ADDR(cz_uart_desc) },
> + { "AMDI0022", APD_ADDR(cz_uart_desc) },
> { "AMD0030", },
> { "AMD0040", APD_ADDR(fch_misc_desc)},
> { "HYGO0010", APD_ADDR(wt_i2c_desc) },
> diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
> index 9e204f9b799a..a3a0154da567 100644
> --- a/drivers/tty/serial/8250/8250_dw.c
> +++ b/drivers/tty/serial/8250/8250_dw.c
> @@ -714,6 +714,7 @@ static const struct acpi_device_id dw8250_acpi_match[] = {
> { "APMC0D08", 0},
> { "AMD0020", 0 },
> { "AMDI0020", 0 },
> + { "AMDI0022", 0 },
> { "BRCM2032", 0 },
> { "HISI0031", 0 },
> { },
> --

2021-05-18 18:38:34

by Greg Kroah-Hartman

Subject: Re: [PATCH] serial: 8250_dw: Add device HID for new AMD UART controller

On Mon, May 17, 2021 at 05:01:15PM +0200, Rafael J. Wysocki wrote:
> On Thu, May 13, 2021 at 12:25 AM Maximilian Luz <[email protected]> wrote:
> >
> > Add device HID AMDI0022 to the AMD UART controller driver match table
> > and create a platform device for it. This controller can be found on
> > Microsoft Surface Laptop 4 devices and seems similar enough that we can
> > just copy the existing AMDI0020 entries.
> >
> > Cc: <[email protected]> # 5.10+
> > Tested-by: Sachi King <[email protected]>
> > Signed-off-by: Maximilian Luz <[email protected]>
>
> Acked-by: Rafael J. Wysocki <[email protected]>
>
> or please let me know if this needs to go in through ACPI (I'm
> assuming that it doesn't).

I've already taken it in my tty tree :)

thanks,

greg k-h