2021-05-07 17:42:10

by Daniel Walker (danielwa)

Subject: [PATCH] fsl-usb: add need_oc_pp_cycle flag for 85xx also

From: Gopalakrishnan Santhanam <[email protected]>

Commit e6604a7fd71f9 ("EHCI: Quirk flag for port power handling on overcurrent.")
activated the quirks handling (flag need_oc_pp_cycle) for Freescale 83xx
based boards.
Activate same for 85xx based boards as well.

Cc: [email protected]
Signed-off-by: Gopalakrishnan Santhanam <[email protected]>
Signed-off-by: Daniel Walker <[email protected]>
---
drivers/usb/host/ehci-fsl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
index 6f7bd6641694..c7d74c1a23f5 100644
--- a/drivers/usb/host/ehci-fsl.c
+++ b/drivers/usb/host/ehci-fsl.c
@@ -387,7 +387,7 @@ static int ehci_fsl_setup(struct usb_hcd *hcd)
/* EHCI registers start at offset 0x100 */
ehci->caps = hcd->regs + 0x100;

-#ifdef CONFIG_PPC_83xx
+#if defined(CONFIG_PPC_83xx) || defined(CONFIG_PPC_85xx)
/*
* Deal with MPC834X that need port power to be cycled after the power
* fault condition is removed. Otherwise the state machine does not
--
2.25.1

2021-05-13 10:43:57

by Gopalakrishnan Santhanam

Subject: [PATCH v2] fsl-usb: add need_oc_pp_cycle flag for 85xx also

Commit e6604a7fd71f9 ("EHCI: Quirk flag for port power handling
on overcurrent.") activated the quirks handling (flag need_oc_pp_cycle)
for Freescale 83xx based boards.
Activate same for 85xx based boards as well.

Cc: [email protected]
Signed-off-by: Gopalakrishnan Santhanam <[email protected]>
Signed-off-by: Daniel Walker <[email protected]>
---
drivers/usb/host/ehci-fsl.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
index 6f7bd6641694..385be30baad3 100644
--- a/drivers/usb/host/ehci-fsl.c
+++ b/drivers/usb/host/ehci-fsl.c
@@ -387,11 +387,11 @@ static int ehci_fsl_setup(struct usb_hcd *hcd)
/* EHCI registers start at offset 0x100 */
ehci->caps = hcd->regs + 0x100;

-#ifdef CONFIG_PPC_83xx
+#if defined(CONFIG_PPC_83xx) || defined(CONFIG_PPC_85xx)
/*
- * Deal with MPC834X that need port power to be cycled after the power
- * fault condition is removed. Otherwise the state machine does not
- * reflect PORTSC[CSC] correctly.
+ * Deal with MPC834X/85XX that need port power to be cycled
+ * after the power fault condition is removed. Otherwise the
+ * state machine does not reflect PORTSC[CSC] correctly.
*/
ehci->need_oc_pp_cycle = 1;
#endif
--
2.26.2.Cisco

2021-05-13 14:45:30

by Alan Stern

Subject: Re: [PATCH v2] fsl-usb: add need_oc_pp_cycle flag for 85xx also

On Thu, May 13, 2021 at 02:02:25PM +0530, Gopalakrishnan Santhanam wrote:
> Commit e6604a7fd71f9 ("EHCI: Quirk flag for port power handling
> on overcurrent.") activated the quirks handling (flag need_oc_pp_cycle)
> for Freescale 83xx based boards.
> Activate same for 85xx based boards as well.
>
> Cc: [email protected]
> Signed-off-by: Gopalakrishnan Santhanam <[email protected]>
> Signed-off-by: Daniel Walker <[email protected]>
> ---

Acked-by: Alan Stern <[email protected]>

> drivers/usb/host/ehci-fsl.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
> index 6f7bd6641694..385be30baad3 100644
> --- a/drivers/usb/host/ehci-fsl.c
> +++ b/drivers/usb/host/ehci-fsl.c
> @@ -387,11 +387,11 @@ static int ehci_fsl_setup(struct usb_hcd *hcd)
> /* EHCI registers start at offset 0x100 */
> ehci->caps = hcd->regs + 0x100;
>
> -#ifdef CONFIG_PPC_83xx
> +#if defined(CONFIG_PPC_83xx) || defined(CONFIG_PPC_85xx)
> /*
> - * Deal with MPC834X that need port power to be cycled after the power
> - * fault condition is removed. Otherwise the state machine does not
> - * reflect PORTSC[CSC] correctly.
> + * Deal with MPC834X/85XX that need port power to be cycled
> + * after the power fault condition is removed. Otherwise the
> + * state machine does not reflect PORTSC[CSC] correctly.
> */
> ehci->need_oc_pp_cycle = 1;
> #endif
> --
> 2.26.2.Cisco
>