2021-05-14 13:11:36

by Chris Chiu

Subject: [PATCH v4 0/2] USB: propose a generic fix for PORT_SUSPEND set feature timeout

From: Chris Chiu <[email protected]>

For the Realtek Hub which fails to resume the port which has wakeup
enable descendants, trying to propose a more generic and better fix
to have the runtime suspend/resume work instead of a reset-resume quirk.

Chris Chiu (2):
USB: Verify the port status when timeout happens during port suspend
Revert "USB: Add reset-resume quirk for WD19's Realtek Hub"

drivers/usb/core/hub.c | 21 +++++++++++++++++++++
drivers/usb/core/quirks.c | 1 -
2 files changed, 21 insertions(+), 1 deletion(-)

--
2.20.1

2021-05-14 13:43:57

by Chris Chiu

Subject: [PATCH v4 2/2] Revert "USB: Add reset-resume quirk for WD19's Realtek Hub"

From: Chris Chiu <[email protected]>

This reverts commit ca91fd8c7643 ("USB: Add reset-resume quirk for
WD19's Realtek Hub"). The previous patch in the series now handles
the problematic hubs by checking the port status and handling it
accordingly when PORT_SUSPEND timeout occurs. We don't need to use
reset-resume all the time.

Signed-off-by: Chris Chiu <[email protected]>
---

Changelog:
v4:
- correct the format of commit reference in the commit message
- rephrase the commit message properly

drivers/usb/core/quirks.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 21e7522655ac..6114cf83bb44 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -406,7 +406,6 @@ static const struct usb_device_id usb_quirk_list[] = {

/* Realtek hub in Dell WD19 (Type-C) */
{ USB_DEVICE(0x0bda, 0x0487), .driver_info = USB_QUIRK_NO_LPM },
- { USB_DEVICE(0x0bda, 0x5487), .driver_info = USB_QUIRK_RESET_RESUME },

/* Generic RTL8153 based ethernet adapters */
{ USB_DEVICE(0x0bda, 0x8153), .driver_info = USB_QUIRK_NO_LPM },
--
2.20.1

2021-05-14 19:32:56

by Alan Stern

Subject: Re: [PATCH v4 0/2] USB: propose a generic fix for PORT_SUSPEND set feature timeout

On Fri, May 14, 2021 at 12:54:03PM +0800, [email protected] wrote:
> From: Chris Chiu <[email protected]>
>
> For the Realtek Hub which fails to resume the port which has wakeup
> enable descendants, trying to propose a more generic and better fix
> to have the runtime suspend/resume work instead of a reset-resume quirk.
>
> Chris Chiu (2):
> USB: Verify the port status when timeout happens during port suspend
> Revert "USB: Add reset-resume quirk for WD19's Realtek Hub"
>
> drivers/usb/core/hub.c | 21 +++++++++++++++++++++
> drivers/usb/core/quirks.c | 1 -
> 2 files changed, 21 insertions(+), 1 deletion(-)

For both patches:

Acked-by: Alan Stern <[email protected]>