2021-05-14 09:55:11

by Qiheng Lin

Subject: [PATCH -next] misc/pvpanic: add missing MODULE_DEVICE_TABLE

This patch adds missing MODULE_DEVICE_TABLE definition which generates
correct modalias for automatic loading of this driver when it is built
as an external module.

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Qiheng Lin <[email protected]>
---
drivers/misc/pvpanic/pvpanic-pci.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/misc/pvpanic/pvpanic-pci.c b/drivers/misc/pvpanic/pvpanic-pci.c
index 9ecc4e8559d5..ccd7e32d3f55 100644
--- a/drivers/misc/pvpanic/pvpanic-pci.c
+++ b/drivers/misc/pvpanic/pvpanic-pci.c
@@ -26,6 +26,7 @@ static const struct pci_device_id pvpanic_pci_id_tbl[] = {
{ PCI_DEVICE(PCI_VENDOR_ID_REDHAT, PCI_DEVICE_ID_REDHAT_PVPANIC)},
{}
};
+MODULE_DEVICE_TABLE(pci, pvpanic_pci_id_tbl);

static ssize_t capability_show(struct device *dev,
struct device_attribute *attr, char *buf)

2021-05-14 14:34:50

by Greg Kroah-Hartman

Subject: Re: [PATCH -next] misc/pvpanic: add missing MODULE_DEVICE_TABLE

On Fri, May 14, 2021 at 03:01:03PM +0800, Qiheng Lin wrote:
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Qiheng Lin <[email protected]>
> ---
> drivers/misc/pvpanic/pvpanic-pci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/misc/pvpanic/pvpanic-pci.c b/drivers/misc/pvpanic/pvpanic-pci.c
> index 9ecc4e8559d5..ccd7e32d3f55 100644
> --- a/drivers/misc/pvpanic/pvpanic-pci.c
> +++ b/drivers/misc/pvpanic/pvpanic-pci.c
> @@ -26,6 +26,7 @@ static const struct pci_device_id pvpanic_pci_id_tbl[] = {
> { PCI_DEVICE(PCI_VENDOR_ID_REDHAT, PCI_DEVICE_ID_REDHAT_PVPANIC)},
> {}
> };
> +MODULE_DEVICE_TABLE(pci, pvpanic_pci_id_tbl);
>
> static ssize_t capability_show(struct device *dev,
> struct device_attribute *attr, char *buf)
>

As I have said before, unless you have a user that reports a real
problem with these types of modules not automatically loading, I am not
going to take these patches, and you should probably stop generating
them.

thanks,

greg k-h