2021-04-25 21:16:04

by Andi Kleen

Subject: [PATCH] poly1305: Make prototypes match

From: Andi Kleen <[email protected]>

gcc 11 complains when arrays in prototypes do not match the function.
Fix this here.

Cc: Jason A. Donenfeld <[email protected]>
Cc: Herbert Xu <[email protected]>
Signed-off-by: Andi Kleen <[email protected]>
---
include/crypto/internal/poly1305.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/crypto/internal/poly1305.h b/include/crypto/internal/poly1305.h
index 064e52ca5248..90ee36411e36 100644
--- a/include/crypto/internal/poly1305.h
+++ b/include/crypto/internal/poly1305.h
@@ -18,7 +18,7 @@
* only the ε-almost-∆-universal hash function (not the full MAC) is computed.
*/

-void poly1305_core_setkey(struct poly1305_core_key *key, const u8 *raw_key);
+void poly1305_core_setkey(struct poly1305_core_key *key, const u8 raw_key[16]);
static inline void poly1305_core_init(struct poly1305_state *state)
{
*state = (struct poly1305_state){};
--
2.25.4

2021-05-14 11:06:24

by Herbert Xu

Subject: Re: [PATCH] poly1305: Make prototypes match

On Sun, Apr 25, 2021 at 02:13:25PM -0700, Andi Kleen wrote:
> From: Andi Kleen <[email protected]>
>
> gcc 11 complains when arrays in prototypes do not match the function.
> Fix this here.
>
> Cc: Jason A. Donenfeld <[email protected]>
> Cc: Herbert Xu <[email protected]>
> Signed-off-by: Andi Kleen <[email protected]>
> ---
> include/crypto/internal/poly1305.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Just noticed that this wasn't cc'ed to linux-crypto. Andi, could
you please resend with a cc to the list?

Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

2021-05-14 19:03:01

by Andi Kleen

Subject: Re: [PATCH] poly1305: Make prototypes match

On Fri, May 14, 2021 at 06:48:13PM +0800, Herbert Xu wrote:
> On Sun, Apr 25, 2021 at 02:13:25PM -0700, Andi Kleen wrote:
> > From: Andi Kleen <[email protected]>
> >
> > gcc 11 complains when arrays in prototypes do not match the function.
> > Fix this here.
> >
> > Cc: Jason A. Donenfeld <[email protected]>
> > Cc: Herbert Xu <[email protected]>
> > Signed-off-by: Andi Kleen <[email protected]>
> > ---
> > include/crypto/internal/poly1305.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Just noticed that this wasn't cc'ed to linux-crypto. Andi, could
> you please resend with a cc to the list?

I thought it was already fixed by Arnd? I think I collided with him.

-Andi

2021-05-17 02:04:28

by Herbert Xu

Subject: Re: [PATCH] poly1305: Make prototypes match

On Fri, May 14, 2021 at 07:13:57AM -0700, Andi Kleen wrote:
>
> I thought it was already fixed by Arnd? I think I collided with him.

Nevermind, you are right Andi.

Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt