2021-05-15 11:12:13

by Alexandru Ardelean

Subject: [PATCH] gpio: gpio-tps6586x: remove platform_set_drvdata() + cleanup probe

The platform_set_drvdata() call is only useful if we need to retrieve back
the private information.
Since the driver doesn't do that, it's not useful to have it.

If this is removed, we can also just do a direct return on
devm_gpiochip_add_data(). We don't need to print that this call failed as
there are other ways to log/see this during probe.

Signed-off-by: Alexandru Ardelean <[email protected]>
---
drivers/gpio/gpio-tps6586x.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/drivers/gpio/gpio-tps6586x.c b/drivers/gpio/gpio-tps6586x.c
index 9b6cc74f47c8..20c4f96f42f0 100644
--- a/drivers/gpio/gpio-tps6586x.c
+++ b/drivers/gpio/gpio-tps6586x.c
@@ -76,7 +76,6 @@ static int tps6586x_gpio_probe(struct platform_device *pdev)
{
struct tps6586x_platform_data *pdata;
struct tps6586x_gpio *tps6586x_gpio;
- int ret;

pdata = dev_get_platdata(pdev->dev.parent);
tps6586x_gpio = devm_kzalloc(&pdev->dev,
@@ -106,16 +105,7 @@ static int tps6586x_gpio_probe(struct platform_device *pdev)
else
tps6586x_gpio->gpio_chip.base = -1;

- ret = devm_gpiochip_add_data(&pdev->dev, &tps6586x_gpio->gpio_chip,
- tps6586x_gpio);
- if (ret < 0) {
- dev_err(&pdev->dev, "Could not register gpiochip, %d\n", ret);
- return ret;
- }
-
- platform_set_drvdata(pdev, tps6586x_gpio);
-
- return ret;
+ return devm_gpiochip_add_data(&pdev->dev, &tps6586x_gpio->gpio_chip, tps6586x_gpio);
}

static struct platform_driver tps6586x_gpio_driver = {
--
2.31.1

2021-05-24 19:00:44

by Bartosz Golaszewski

Subject: Re: [PATCH] gpio: gpio-tps6586x: remove platform_set_drvdata() + cleanup probe

On Sat, May 15, 2021 at 9:52 AM Alexandru Ardelean
<[email protected]> wrote:
>
> The platform_set_drvdata() call is only useful if we need to retrieve back
> the private information.
> Since the driver doesn't do that, it's not useful to have it.
>
> If this is removed, we can also just do a direct return on
> devm_gpiochip_add_data(). We don't need to print that this call failed as
> there are other ways to log/see this during probe.
>
> Signed-off-by: Alexandru Ardelean <[email protected]>
> ---
> drivers/gpio/gpio-tps6586x.c | 12 +-----------
> 1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/drivers/gpio/gpio-tps6586x.c b/drivers/gpio/gpio-tps6586x.c
> index 9b6cc74f47c8..20c4f96f42f0 100644
> --- a/drivers/gpio/gpio-tps6586x.c
> +++ b/drivers/gpio/gpio-tps6586x.c
> @@ -76,7 +76,6 @@ static int tps6586x_gpio_probe(struct platform_device *pdev)
> {
> struct tps6586x_platform_data *pdata;
> struct tps6586x_gpio *tps6586x_gpio;
> - int ret;
>
> pdata = dev_get_platdata(pdev->dev.parent);
> tps6586x_gpio = devm_kzalloc(&pdev->dev,
> @@ -106,16 +105,7 @@ static int tps6586x_gpio_probe(struct platform_device *pdev)
> else
> tps6586x_gpio->gpio_chip.base = -1;
>
> - ret = devm_gpiochip_add_data(&pdev->dev, &tps6586x_gpio->gpio_chip,
> - tps6586x_gpio);
> - if (ret < 0) {
> - dev_err(&pdev->dev, "Could not register gpiochip, %d\n", ret);
> - return ret;
> - }
> -
> - platform_set_drvdata(pdev, tps6586x_gpio);
> -
> - return ret;
> + return devm_gpiochip_add_data(&pdev->dev, &tps6586x_gpio->gpio_chip, tps6586x_gpio);
> }
>
> static struct platform_driver tps6586x_gpio_driver = {
> --
> 2.31.1
>

Applied, thanks!

Bart