2021-05-17 13:06:02

by Yang Shen

[permalink] [raw]
Subject: [PATCH v2 00/24] Rid W=1 warnings in net

This is 1 of 2 sets to fully clean drivers/net.

Changes since v1:
- add some warnings missed in v1
- move the patches about drivers/net/wireless into another series

Yang Shen (24):
net: arc: Demote non-compliant kernel-doc headers
net: atheros: atl1c: Fix wrong function name in comments
net: atheros: atl1e: Fix wrong function name in comments
net: atheros: atl1x: Fix wrong function name in comments
net: broadcom: bnx2x: Fix wrong function name in comments
net: brocade: bna: Fix wrong function name in comments
net: cadence: Demote non-compliant kernel-doc headers
net: calxeda: Fix wrong function name in comments
net: chelsio: cxgb3: Fix wrong function name in comments
net: chelsio: cxgb4: Fix wrong function name in comments
net: chelsio: cxgb4vf: Fix wrong function name in comments
net: huawei: hinic: Fix wrong function name in comments
net: micrel: Fix wrong function name in comments
net: microchip: Demote non-compliant kernel-doc headers
net: neterion: Fix wrong function name in comments
net: neterion: vxge: Fix wrong function name in comments
net: netronome: nfp: Fix wrong function name in comments
net: calxeda: Fix wrong function name in comments
net: samsung: sxgbe: Fix wrong function name in comments
net: socionext: Demote non-compliant kernel-doc headers
net: ti: Fix wrong struct name in comments
net: via: Fix wrong function name in comments
net: phy: Demote non-compliant kernel-doc headers
net: hisilicon: hns: Fix wrong function name in comments

drivers/net/ethernet/arc/emac_rockchip.c | 2 +-
drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 6 +++---
drivers/net/ethernet/atheros/atl1e/atl1e_main.c | 4 ++--
drivers/net/ethernet/atheros/atlx/atl1.c | 2 +-
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 2 +-
drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c | 4 ++--
drivers/net/ethernet/brocade/bna/bfa_cee.c | 2 +-
drivers/net/ethernet/cadence/macb_pci.c | 2 +-
drivers/net/ethernet/cadence/macb_ptp.c | 2 +-
drivers/net/ethernet/calxeda/xgmac.c | 8 ++++----
drivers/net/ethernet/chelsio/cxgb3/sge.c | 4 ++--
drivers/net/ethernet/chelsio/cxgb4/cxgb4_ptp.c | 2 +-
drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 4 ++--
drivers/net/ethernet/chelsio/cxgb4vf/sge.c | 2 +-
.../net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 6 +++---
.../net/ethernet/hisilicon/hns/hns_dsaf_main.c | 16 ++++++++--------
.../net/ethernet/hisilicon/hns/hns_dsaf_misc.c | 4 ++--
.../net/ethernet/hisilicon/hns/hns_dsaf_ppe.c | 8 ++++----
.../net/ethernet/hisilicon/hns/hns_dsaf_rcb.c | 2 +-
.../net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c | 4 ++--
drivers/net/ethernet/hisilicon/hns/hns_enet.c | 2 +-
drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 6 +++---
.../net/ethernet/huawei/hinic/hinic_hw_cmdq.c | 2 +-
drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c | 8 ++++----
drivers/net/ethernet/huawei/hinic/hinic_hw_if.c | 2 +-
drivers/net/ethernet/huawei/hinic/hinic_hw_qp.c | 2 +-
drivers/net/ethernet/huawei/hinic/hinic_main.c | 4 ++--
drivers/net/ethernet/huawei/hinic/hinic_tx.c | 2 +-
drivers/net/ethernet/micrel/ksz884x.c | 6 +++---
drivers/net/ethernet/microchip/encx24j600.c | 2 +-
drivers/net/ethernet/neterion/s2io.c | 4 ++--
drivers/net/ethernet/neterion/vxge/vxge-config.c | 2 +-
drivers/net/ethernet/neterion/vxge/vxge-main.c | 4 ++--
drivers/net/ethernet/netronome/nfp/ccm_mbox.c | 2 +-
.../ethernet/netronome/nfp/flower/tunnel_conf.c | 2 +-
.../ethernet/netronome/nfp/nfpcore/nfp_nffw.c | 2 +-
.../ethernet/qlogic/qlcnic/qlcnic_83xx_init.c | 2 +-
.../ethernet/qlogic/qlcnic/qlcnic_83xx_vnic.c | 2 +-
drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c | 4 ++--
drivers/net/ethernet/socionext/sni_ave.c | 2 +-
drivers/net/ethernet/ti/cpsw_ale.c | 2 +-
drivers/net/ethernet/via/via-velocity.c | 6 +++---
drivers/net/phy/adin.c | 2 +-
drivers/net/phy/rockchip.c | 2 +-
44 files changed, 80 insertions(+), 80 deletions(-)

--
2.17.1



2021-05-17 13:06:22

by Yang Shen

[permalink] [raw]
Subject: [PATCH v2 16/24] net: neterion: vxge: Fix wrong function name in comments

Fixes the following W=1 kernel build warning(s):

drivers/net/ethernet/neterion/vxge/vxge-config.c:4895: warning: expecting prototype for vxge_hw_vpath_rx_doorbell_post(). Prototype was for vxge_hw_vpath_rx_doorbell_init() instead
drivers/net/ethernet/neterion/vxge/vxge-main.c:1814: warning: expecting prototype for vxge_poll(). Prototype was for vxge_poll_msix() instead
drivers/net/ethernet/neterion/vxge/vxge-main.c:4761: warning: expecting prototype for vxge_rem_nic(). Prototype was for vxge_remove() instead

Cc: Jon Mason <[email protected]>
Signed-off-by: Yang Shen <[email protected]>
---
drivers/net/ethernet/neterion/vxge/vxge-config.c | 2 +-
drivers/net/ethernet/neterion/vxge/vxge-main.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/neterion/vxge/vxge-config.c b/drivers/net/ethernet/neterion/vxge/vxge-config.c
index 5162b938a1ac..38a273c4d593 100644
--- a/drivers/net/ethernet/neterion/vxge/vxge-config.c
+++ b/drivers/net/ethernet/neterion/vxge/vxge-config.c
@@ -4884,7 +4884,7 @@ vxge_hw_vpath_open(struct __vxge_hw_device *hldev,
}

/**
- * vxge_hw_vpath_rx_doorbell_post - Close the handle got from previous vpath
+ * vxge_hw_vpath_rx_doorbell_init - Close the handle got from previous vpath
* (vpath) open
* @vp: Handle got from previous vpath open
*
diff --git a/drivers/net/ethernet/neterion/vxge/vxge-main.c b/drivers/net/ethernet/neterion/vxge/vxge-main.c
index 87892bd992b1..b113c158d6e3 100644
--- a/drivers/net/ethernet/neterion/vxge/vxge-main.c
+++ b/drivers/net/ethernet/neterion/vxge/vxge-main.c
@@ -1799,7 +1799,7 @@ static void vxge_reset(struct work_struct *work)
}

/**
- * vxge_poll - Receive handler when Receive Polling is used.
+ * vxge_poll_msix - Receive handler when Receive Polling is used.
* @napi: pointer to the napi structure.
* @budget: Number of packets budgeted to be processed in this iteration.
*
@@ -4752,7 +4752,7 @@ vxge_probe(struct pci_dev *pdev, const struct pci_device_id *pre)
}

/**
- * vxge_rem_nic - Free the PCI device
+ * vxge_remove - Free the PCI device
* @pdev: structure containing the PCI related information of the device.
* Description: This function is called by the Pci subsystem to release a
* PCI device and free up all resource held up by the device.
--
2.17.1


2021-05-17 13:06:23

by Yang Shen

[permalink] [raw]
Subject: [PATCH v2 19/24] net: samsung: sxgbe: Fix wrong function name in comments

Fixes the following W=1 kernel build warning(s):

drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c:797: warning: expecting prototype for sxgbe_tx_clean(). Prototype was for sxgbe_tx_all_clean() instead
drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c:1026: warning: expecting prototype for sxgbe_init_tx_coalesce(). Prototype was for sxgbe_tx_init_coalesce() instead

Cc: Byungho An <[email protected]>
Signed-off-by: Yang Shen <[email protected]>
---
drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c b/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c
index 971f1e54b652..090bcd2fb758 100644
--- a/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c
+++ b/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c
@@ -789,7 +789,7 @@ static void sxgbe_tx_queue_clean(struct sxgbe_tx_queue *tqueue)
}

/**
- * sxgbe_tx_clean:
+ * sxgbe_tx_all_clean:
* @priv: driver private structure
* Description: it reclaims resources after transmission completes.
*/
@@ -1015,7 +1015,7 @@ static void sxgbe_tx_timer(struct timer_list *t)
}

/**
- * sxgbe_init_tx_coalesce: init tx mitigation options.
+ * sxgbe_tx_init_coalesce: init tx mitigation options.
* @priv: driver private structure
* Description:
* This inits the transmit coalesce parameters: i.e. timer rate,
--
2.17.1


2021-05-17 13:40:54

by Yang Shen

[permalink] [raw]
Subject: [PATCH v2 18/24] net: calxeda: Fix wrong function name in comments

Fixes the following W=1 kernel build warning(s):

drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c:761: warning: expecting prototype for qlcnic_83xx_idc_cold_state(). Prototype was for qlcnic_83xx_idc_cold_state_handler() instead
drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_vnic.c:192: warning: expecting prototype for qlcnic_83xx_vnic_opmode(). Prototype was for qlcnic_83xx_config_vnic_opmode() instead

Cc: Shahed Shaikh <[email protected]>
Cc: Manish Chopra <[email protected]>
Signed-off-by: Yang Shen <[email protected]>
---
drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c | 2 +-
drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_vnic.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c
index d2c190732d3e..0a2f34fc8b24 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c
@@ -746,7 +746,7 @@ static int qlcnic_83xx_idc_unknown_state(struct qlcnic_adapter *adapter)
}

/**
- * qlcnic_83xx_idc_cold_state
+ * qlcnic_83xx_idc_cold_state_handler
*
* @adapter: adapter structure
*
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_vnic.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_vnic.c
index c4297aea7d15..711609503ba6 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_vnic.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_vnic.c
@@ -180,7 +180,7 @@ static int qlcnic_83xx_init_non_privileged_vnic(struct qlcnic_adapter *adapter)
}

/**
- * qlcnic_83xx_vnic_opmode
+ * qlcnic_83xx_config_vnic_opmode
*
* @adapter: adapter structure
* Identify virtual NIC operational modes.
--
2.17.1


2021-05-19 08:09:30

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH v2 00/24] Rid W=1 warnings in net

Hello:

This series was applied to netdev/net-next.git (refs/heads/master):

On Mon, 17 May 2021 12:45:11 +0800 you wrote:
> This is 1 of 2 sets to fully clean drivers/net.
>
> Changes since v1:
> - add some warnings missed in v1
> - move the patches about drivers/net/wireless into another series
>
> Yang Shen (24):
> net: arc: Demote non-compliant kernel-doc headers
> net: atheros: atl1c: Fix wrong function name in comments
> net: atheros: atl1e: Fix wrong function name in comments
> net: atheros: atl1x: Fix wrong function name in comments
> net: broadcom: bnx2x: Fix wrong function name in comments
> net: brocade: bna: Fix wrong function name in comments
> net: cadence: Demote non-compliant kernel-doc headers
> net: calxeda: Fix wrong function name in comments
> net: chelsio: cxgb3: Fix wrong function name in comments
> net: chelsio: cxgb4: Fix wrong function name in comments
> net: chelsio: cxgb4vf: Fix wrong function name in comments
> net: huawei: hinic: Fix wrong function name in comments
> net: micrel: Fix wrong function name in comments
> net: microchip: Demote non-compliant kernel-doc headers
> net: neterion: Fix wrong function name in comments
> net: neterion: vxge: Fix wrong function name in comments
> net: netronome: nfp: Fix wrong function name in comments
> net: calxeda: Fix wrong function name in comments
> net: samsung: sxgbe: Fix wrong function name in comments
> net: socionext: Demote non-compliant kernel-doc headers
> net: ti: Fix wrong struct name in comments
> net: via: Fix wrong function name in comments
> net: phy: Demote non-compliant kernel-doc headers
> net: hisilicon: hns: Fix wrong function name in comments
>
> [...]

Here is the summary with links:
- [v2,01/24] net: arc: Demote non-compliant kernel-doc headers
https://git.kernel.org/netdev/net-next/c/1d7f7ecadc5a
- [v2,02/24] net: atheros: atl1c: Fix wrong function name in comments
https://git.kernel.org/netdev/net-next/c/8965c1c535b1
- [v2,03/24] net: atheros: atl1e: Fix wrong function name in comments
https://git.kernel.org/netdev/net-next/c/b43e1554a7cf
- [v2,04/24] net: atheros: atl1x: Fix wrong function name in comments
https://git.kernel.org/netdev/net-next/c/c706c75aaee2
- [v2,05/24] net: broadcom: bnx2x: Fix wrong function name in comments
https://git.kernel.org/netdev/net-next/c/76d85049173b
- [v2,06/24] net: brocade: bna: Fix wrong function name in comments
https://git.kernel.org/netdev/net-next/c/5a02bf4fefd5
- [v2,07/24] net: cadence: Demote non-compliant kernel-doc headers
https://git.kernel.org/netdev/net-next/c/c1167cee462d
- [v2,08/24] net: calxeda: Fix wrong function name in comments
https://git.kernel.org/netdev/net-next/c/2e45d961a6a8
- [v2,09/24] net: chelsio: cxgb3: Fix wrong function name in comments
https://git.kernel.org/netdev/net-next/c/aeed744a49ba
- [v2,10/24] net: chelsio: cxgb4: Fix wrong function name in comments
https://git.kernel.org/netdev/net-next/c/e0333b1bb174
- [v2,11/24] net: chelsio: cxgb4vf: Fix wrong function name in comments
https://git.kernel.org/netdev/net-next/c/1eb00ff517f4
- [v2,12/24] net: huawei: hinic: Fix wrong function name in comments
https://git.kernel.org/netdev/net-next/c/d6174870c0f1
- [v2,13/24] net: micrel: Fix wrong function name in comments
https://git.kernel.org/netdev/net-next/c/229fd41f6447
- [v2,14/24] net: microchip: Demote non-compliant kernel-doc headers
https://git.kernel.org/netdev/net-next/c/331a3219d3b6
- [v2,15/24] net: neterion: Fix wrong function name in comments
https://git.kernel.org/netdev/net-next/c/dc432f5acb86
- [v2,16/24] net: neterion: vxge: Fix wrong function name in comments
https://git.kernel.org/netdev/net-next/c/146c91e2bc9a
- [v2,17/24] net: netronome: nfp: Fix wrong function name in comments
https://git.kernel.org/netdev/net-next/c/a507b1644524
- [v2,18/24] net: calxeda: Fix wrong function name in comments
https://git.kernel.org/netdev/net-next/c/9f2e6fb63413
- [v2,19/24] net: samsung: sxgbe: Fix wrong function name in comments
https://git.kernel.org/netdev/net-next/c/61633d71a71c
- [v2,20/24] net: socionext: Demote non-compliant kernel-doc headers
https://git.kernel.org/netdev/net-next/c/40d9fca8b3fd
- [v2,21/24] net: ti: Fix wrong struct name in comments
https://git.kernel.org/netdev/net-next/c/85ead77dc3d5
- [v2,22/24] net: via: Fix wrong function name in comments
https://git.kernel.org/netdev/net-next/c/03055a25213b
- [v2,23/24] net: phy: Demote non-compliant kernel-doc headers
https://git.kernel.org/netdev/net-next/c/1f2d109e8363
- [v2,24/24] net: hisilicon: hns: Fix wrong function name in comments
https://git.kernel.org/netdev/net-next/c/5a9594cf1d14

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html