It seems there is some need to have an ability to invoke perf from
build directory without installation
(84cfac7f05e1: perf tools: Set and pass DOCDIR to builtin-report.c)
DOCDIR definition contains an absolute path to kernel source directory.
It is build machine related info and it makes perf binary unreproducible.
This can be avoided by compiling tips.txt in perf directly.
Signed-off-by: Denys Zagorui <[email protected]>
---
tools/perf/Build | 2 +-
tools/perf/Documentation/Build | 9 ++++++++
tools/perf/builtin-report.c | 39 ++++++++++++++++++++++++++--------
tools/perf/util/util.c | 28 ------------------------
tools/perf/util/util.h | 2 --
5 files changed, 40 insertions(+), 40 deletions(-)
create mode 100644 tools/perf/Documentation/Build
diff --git a/tools/perf/Build b/tools/perf/Build
index db61dbe2b543..3a2e768d7576 100644
--- a/tools/perf/Build
+++ b/tools/perf/Build
@@ -45,12 +45,12 @@ CFLAGS_perf.o += -DPERF_HTML_PATH="BUILD_STR($(htmldir_SQ))" \
-DPREFIX="BUILD_STR($(prefix_SQ))"
CFLAGS_builtin-trace.o += -DSTRACE_GROUPS_DIR="BUILD_STR($(STRACE_GROUPS_DIR_SQ))"
CFLAGS_builtin-report.o += -DTIPDIR="BUILD_STR($(tipdir_SQ))"
-CFLAGS_builtin-report.o += -DDOCDIR="BUILD_STR($(srcdir_SQ)/Documentation)"
perf-y += util/
perf-y += arch/
perf-y += ui/
perf-y += scripts/
perf-$(CONFIG_TRACE) += trace/beauty/
+perf-y += Documentation/
gtk-y += ui/gtk/
diff --git a/tools/perf/Documentation/Build b/tools/perf/Documentation/Build
new file mode 100644
index 000000000000..83e16764caa4
--- /dev/null
+++ b/tools/perf/Documentation/Build
@@ -0,0 +1,9 @@
+perf-y += tips.o
+
+quiet_cmd_ld_tips = LD $@
+ cmd_ld_tips = $(LD) -r -b binary -o $@ $<
+
+$(OUTPUT)Documentation/tips.o: Documentation/tips.txt FORCE
+ $(call rule_mkdir)
+ $(call if_changed,ld_tips)
+
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 36f9ccfeb38a..ef6f25a521b4 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -47,7 +47,6 @@
#include "util/time-utils.h"
#include "util/auxtrace.h"
#include "util/units.h"
-#include "util/util.h" // perf_tip()
#include "ui/ui.h"
#include "ui/progress.h"
#include "util/block-info.h"
@@ -109,6 +108,9 @@ struct report {
int nr_block_reports;
};
+extern char _binary_Documentation_tips_txt_start[];
+extern char _binary_Documentation_tips_txt_end[];
+
static int report__config(const char *var, const char *value, void *cb)
{
struct report *rep = cb;
@@ -614,19 +616,38 @@ static int report__gtk_browse_hists(struct report *rep, const char *help)
return hist_browser(rep->session->evlist, help, NULL, rep->min_percent);
}
+#define MAX_TIPS 60
+
+static const char *perf_tip(void)
+{
+ char *str[MAX_TIPS];
+ int i = 0;
+
+ _binary_Documentation_tips_txt_start[_binary_Documentation_tips_txt_end -
+ _binary_Documentation_tips_txt_start - 1] = 0;
+
+ str[i] = strtok(_binary_Documentation_tips_txt_start, "\n");
+ if (!str[i])
+ return "Tips cannot be found!";
+
+ i++;
+
+ while (i < MAX_TIPS) {
+ str[i] = strtok(NULL, "\n");
+ if (!str[i])
+ break;
+ i++;
+ }
+
+ return str[random() % i];
+}
+
static int report__browse_hists(struct report *rep)
{
int ret;
struct perf_session *session = rep->session;
struct evlist *evlist = session->evlist;
- const char *help = perf_tip(system_path(TIPDIR));
-
- if (help == NULL) {
- /* fallback for people who don't install perf ;-) */
- help = perf_tip(DOCDIR);
- if (help == NULL)
- help = "Cannot load tips.txt file, please install perf!";
- }
+ const char *help = perf_tip();
switch (use_browser) {
case 1:
diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c
index 37a9492edb3e..3bba74e431ed 100644
--- a/tools/perf/util/util.c
+++ b/tools/perf/util/util.c
@@ -379,34 +379,6 @@ fetch_kernel_version(unsigned int *puint, char *str,
return 0;
}
-const char *perf_tip(const char *dirpath)
-{
- struct strlist *tips;
- struct str_node *node;
- char *tip = NULL;
- struct strlist_config conf = {
- .dirname = dirpath,
- .file_only = true,
- };
-
- tips = strlist__new("tips.txt", &conf);
- if (tips == NULL)
- return errno == ENOENT ? NULL :
- "Tip: check path of tips.txt or get more memory! ;-p";
-
- if (strlist__nr_entries(tips) == 0)
- goto out;
-
- node = strlist__entry(tips, random() % strlist__nr_entries(tips));
- if (asprintf(&tip, "Tip: %s", node->s) < 0)
- tip = (char *)"Tip: get more memory! ;-)";
-
-out:
- strlist__delete(tips);
-
- return tip;
-}
-
char *perf_exe(char *buf, int len)
{
int n = readlink("/proc/self/exe", buf, len);
diff --git a/tools/perf/util/util.h b/tools/perf/util/util.h
index ad737052e597..80b194ee6c7d 100644
--- a/tools/perf/util/util.h
+++ b/tools/perf/util/util.h
@@ -39,8 +39,6 @@ int fetch_kernel_version(unsigned int *puint,
#define KVER_FMT "%d.%d.%d"
#define KVER_PARAM(x) KVER_VERSION(x), KVER_PATCHLEVEL(x), KVER_SUBLEVEL(x)
-const char *perf_tip(const char *dirpath);
-
#ifndef HAVE_SCHED_GETCPU_SUPPORT
int sched_getcpu(void);
#endif
--
2.26.2.Cisco
During perf build with O= bison stores full paths in generated files and
those paths are stored in resulting perf binary. Starting from v3.7.1.
those paths can be remapped by using --file-prefix-map option. Use this
option if it possible to make perf binary more reproducible.
Signed-off-by: Denys Zagorui <[email protected]>
---
tools/perf/Makefile.config | 9 +++++++++
tools/perf/util/Build | 6 +++---
2 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
index 406a9519145e..dacd16874d3d 100644
--- a/tools/perf/Makefile.config
+++ b/tools/perf/Makefile.config
@@ -202,6 +202,12 @@ ifeq ($(call get-executable,$(BISON)),)
dummy := $(error Error: $(BISON) is missing on this system, please install it)
endif
+ifneq ($(OUTPUT),)
+ ifeq ($(shell expr $(shell $(BISON) --version | grep bison | sed -e 's/.\+ \([0-9]\+\).\([0-9]\+\).\([0-9]\+\)/\1\2\3/g') \>\= 371), 1)
+ BISON_FILE_PREFIX_MAP := --file-prefix-map=$(OUTPUT)=
+ endif
+endif
+
# Treat warnings as errors unless directed not to
ifneq ($(WERROR),0)
CORE_CFLAGS += -Werror
@@ -1228,6 +1234,9 @@ $(call detected_var,LIBDIR)
$(call detected_var,GTK_CFLAGS)
$(call detected_var,PERL_EMBED_CCOPTS)
$(call detected_var,PYTHON_EMBED_CCOPTS)
+ifneq ($(BISON_FILE_PREFIX_MAP),)
+$(call detected_var,BISON_FILE_PREFIX_MAP)
+endif
# re-generate FEATURE-DUMP as we may have called feature_check, found out
# extra libraries to add to LDFLAGS of some other test and then redo those
diff --git a/tools/perf/util/Build b/tools/perf/util/Build
index b64bdc1a7026..95e15d1035ab 100644
--- a/tools/perf/util/Build
+++ b/tools/perf/util/Build
@@ -216,7 +216,7 @@ $(OUTPUT)util/parse-events-flex.c $(OUTPUT)util/parse-events-flex.h: util/parse-
$(OUTPUT)util/parse-events-bison.c $(OUTPUT)util/parse-events-bison.h: util/parse-events.y
$(call rule_mkdir)
- $(Q)$(call echo-cmd,bison)$(BISON) -v $< -d $(PARSER_DEBUG_BISON) \
+ $(Q)$(call echo-cmd,bison)$(BISON) -v $< -d $(PARSER_DEBUG_BISON) $(BISON_FILE_PREFIX_MAP) \
-o $(OUTPUT)util/parse-events-bison.c -p parse_events_
$(OUTPUT)util/expr-flex.c $(OUTPUT)util/expr-flex.h: util/expr.l $(OUTPUT)util/expr-bison.c
@@ -226,7 +226,7 @@ $(OUTPUT)util/expr-flex.c $(OUTPUT)util/expr-flex.h: util/expr.l $(OUTPUT)util/e
$(OUTPUT)util/expr-bison.c $(OUTPUT)util/expr-bison.h: util/expr.y
$(call rule_mkdir)
- $(Q)$(call echo-cmd,bison)$(BISON) -v $< -d $(PARSER_DEBUG_BISON) \
+ $(Q)$(call echo-cmd,bison)$(BISON) -v $< -d $(PARSER_DEBUG_BISON) $(BISON_FILE_PREFIX_MAP) \
-o $(OUTPUT)util/expr-bison.c -p expr_
$(OUTPUT)util/pmu-flex.c $(OUTPUT)util/pmu-flex.h: util/pmu.l $(OUTPUT)util/pmu-bison.c
@@ -236,7 +236,7 @@ $(OUTPUT)util/pmu-flex.c $(OUTPUT)util/pmu-flex.h: util/pmu.l $(OUTPUT)util/pmu-
$(OUTPUT)util/pmu-bison.c $(OUTPUT)util/pmu-bison.h: util/pmu.y
$(call rule_mkdir)
- $(Q)$(call echo-cmd,bison)$(BISON) -v $< -d $(PARSER_DEBUG_BISON) \
+ $(Q)$(call echo-cmd,bison)$(BISON) -v $< -d $(PARSER_DEBUG_BISON) $(BISON_FILE_PREFIX_MAP) \
-o $(OUTPUT)util/pmu-bison.c -p perf_pmu_
FLEX_GE_26 := $(shell expr $(shell $(FLEX) --version | sed -e 's/flex \([0-9]\+\).\([0-9]\+\)/\1\2/g') \>\= 26)
--
2.26.2.Cisco
On Mon, May 17, 2021 at 01:46:02AM -0700, Denys Zagorui wrote:
SNIP
> return hist_browser(rep->session->evlist, help, NULL, rep->min_percent);
> }
>
> +#define MAX_TIPS 60
> +
> +static const char *perf_tip(void)
> +{
> + char *str[MAX_TIPS];
> + int i = 0;
> +
> + _binary_Documentation_tips_txt_start[_binary_Documentation_tips_txt_end -
> + _binary_Documentation_tips_txt_start - 1] = 0;
> +
> + str[i] = strtok(_binary_Documentation_tips_txt_start, "\n");
> + if (!str[i])
> + return "Tips cannot be found!";
> +
> + i++;
> +
> + while (i < MAX_TIPS) {
> + str[i] = strtok(NULL, "\n");
> + if (!str[i])
> + break;
> + i++;
> + }
> +
> + return str[random() % i];
that still does not solve that we set MAX_TIPS and have
no way of checking that's still valid
how about something like below (completely untested):
static const char *perf_tip(void)
{
char *start = _binary_Documentation_tips_txt_start;
char *tok, *tmp, *prev;
int pick, size;
size = _binary_Documentation_tips_txt_end - start;
pick = random() % size;
_binary_Documentation_tips_txt_start[size - 1] = 0;
for (tok = strtok_r(start, "\n", &tmp); tok;
tok = strtok_r(NULL, "\n", &tmp)) {
if (pick < (tok - start))
return prev;
prev = tok;
}
return prev;
}
this way you wouldn't need array with MAX_TIPS defined
jirka
> that still does not solve that we set MAX_TIPS and have
> no way of checking that's still valid
>
> how about something like below (completely untested):
Yes, looks good, i've tested it.
>
>
> static const char *perf_tip(void)
> {
> char *start = _binary_Documentation_tips_txt_start;
> char *tok, *tmp, *prev;
> int pick, size;
>
> size = _binary_Documentation_tips_txt_end - start;
> pick = random() % size;
>
> _binary_Documentation_tips_txt_start[size - 1] = 0;
>
> for (tok = strtok_r(start, "\n", &tmp); tok;
> tok = strtok_r(NULL, "\n", &tmp)) {
> if (pick < (tok - start))
> return prev;
> prev = tok;
> }
>
> return prev;
> }
>
> this way you wouldn't need array with MAX_TIPS defined