2021-05-19 17:56:58

by Jiabing Wan

[permalink] [raw]
Subject: [PATCH] [v2] staging: media: atomisp: Align block comments

From: Jiabing Wan <[email protected]>

Fixing the following checkpatch warning:
WARNING: Block comments should align the * on each line

Signed-off-by: Jiabing Wan <[email protected]>
---
Changelog:
v2:
- Fix the author style in patch.
---
.../atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr_types.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr_types.h b/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr_types.h
index be3534e46c15..9b22f2da45d5 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr_types.h
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr_types.h
@@ -17,8 +17,8 @@
#define __IA_CSS_ANR_TYPES_H

/* @file
-* CSS-API header file for Advanced Noise Reduction kernel v1
-*/
+ * CSS-API header file for Advanced Noise Reduction kernel v1
+ */

/* Application specific DMA settings */
#define ANR_BPP 10
--
2.20.1



2021-05-27 00:55:44

by Sakari Ailus

[permalink] [raw]
Subject: Re: [PATCH] [v2] staging: media: atomisp: Align block comments

Hi Jiabing,

On Tue, May 18, 2021 at 07:29:35PM +0800, Wan Jiabing wrote:
> From: Jiabing Wan <[email protected]>
>
> Fixing the following checkpatch warning:
> WARNING: Block comments should align the * on each line
>
> Signed-off-by: Jiabing Wan <[email protected]>
> ---
> Changelog:
> v2:
> - Fix the author style in patch.
> ---
> .../atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr_types.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr_types.h b/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr_types.h
> index be3534e46c15..9b22f2da45d5 100644
> --- a/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr_types.h
> +++ b/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr_types.h
> @@ -17,8 +17,8 @@
> #define __IA_CSS_ANR_TYPES_H
>
> /* @file

Could you fix the first line, too, i.e.:

/*
* ...

> -* CSS-API header file for Advanced Noise Reduction kernel v1
> -*/
> + * CSS-API header file for Advanced Noise Reduction kernel v1
> + */
>
> /* Application specific DMA settings */
> #define ANR_BPP 10

--
Kind regards,

Sakari Ailus