2021-05-19 18:01:03

by Axel Lin

[permalink] [raw]
Subject: [PATCH] regulator: bd71815: Fix missing include files

Include linux/of.h and linux/gpio/consumer.h to fix below errors:
error: implicit declaration of function ‘of_match_ptr’
error: implicit declaration of function ‘devm_gpiod_get_from_of_node’

Signed-off-by: Axel Lin <[email protected]>
---
drivers/regulator/bd71815-regulator.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/regulator/bd71815-regulator.c b/drivers/regulator/bd71815-regulator.c
index a4e8d5e36b40..a079efa80092 100644
--- a/drivers/regulator/bd71815-regulator.c
+++ b/drivers/regulator/bd71815-regulator.c
@@ -13,6 +13,8 @@
#include <linux/init.h>
#include <linux/err.h>
#include <linux/platform_device.h>
+#include <linux/of.h>
+#include <linux/gpio/consumer.h>
#include <linux/regulator/driver.h>
#include <linux/delay.h>
#include <linux/slab.h>
--
2.25.1



2021-05-19 18:04:22

by Matti Vaittinen

[permalink] [raw]
Subject: Re: [PATCH] regulator: bd71815: Fix missing include files


On Tue, 2021-05-18 at 19:48 +0800, Axel Lin wrote:
> Include linux/of.h and linux/gpio/consumer.h to fix below errors:
> error: implicit declaration of function ‘of_match_ptr’
> error: implicit declaration of function ‘devm_gpiod_get_from_of_node’
>
> Signed-off-by: Axel Lin <[email protected]>

Thanks Axel.

Reviewed-by: Matti Vaittinen <[email protected]>



Attachments:
signature.asc (499.00 B)
This is a digitally signed message part

2021-05-19 18:23:45

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] regulator: bd71815: Fix missing include files

On Tue, 18 May 2021 19:48:43 +0800, Axel Lin wrote:
> Include linux/of.h and linux/gpio/consumer.h to fix below errors:
> error: implicit declaration of function ‘of_match_ptr’
> error: implicit declaration of function ‘devm_gpiod_get_from_of_node’

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: bd71815: Fix missing include files
commit: 3799fa23afa4cac347739d5290df44a474a82a82

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark