2021-05-19 18:10:46

by Wei Ming Chen

Subject: [PATCH] scsi: fas216: Use fallthrough pseudo-keyword

Replace /* FALLTHROUGH */ comment with pseudo-keyword macro fallthrough[1]

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

Signed-off-by: Wei Ming Chen <[email protected]>
---
drivers/scsi/arm/fas216.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/arm/fas216.c b/drivers/scsi/arm/fas216.c
index 2e687ce60753..9402cdce7cc5 100644
--- a/drivers/scsi/arm/fas216.c
+++ b/drivers/scsi/arm/fas216.c
@@ -1479,7 +1479,7 @@ static void fas216_busservice_intr(FAS216_Info *info, unsigned int stat, unsigne

if (msgqueue_msglength(&info->scsi.msgs) > 1)
fas216_cmd(info, CMD_SETATN);
- /*FALLTHROUGH*/
+ fallthrough;

/*
* Any -> Message Out
--
2.25.1

2021-05-26 04:33:35

by Martin K. Petersen

Subject: Re: [PATCH] scsi: fas216: Use fallthrough pseudo-keyword

On Tue, 18 May 2021 21:18:23 +0800, Wei Ming Chen wrote:

> Replace /* FALLTHROUGH */ comment with pseudo-keyword macro fallthrough[1]
>
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

Applied to 5.14/scsi-queue, thanks!

[1/1] scsi: fas216: Use fallthrough pseudo-keyword
https://git.kernel.org/mkp/scsi/c/86cfe4ad248d

--
Martin K. Petersen Oracle Linux Engineering