2021-05-19 20:12:48

by F.A.Sulaiman

Subject: [PATCH] Staging: greybus: fix open parenthesis issue in gbphy.c

This fix "Alignment should match open parenthesis" checkpatch error.

Signed-off-by: "F.A.Sulaiman" <[email protected]>
---
drivers/staging/greybus/gbphy.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/greybus/gbphy.c b/drivers/staging/greybus/gbphy.c
index 9fc5c47be9bd..13d319860da5 100644
--- a/drivers/staging/greybus/gbphy.c
+++ b/drivers/staging/greybus/gbphy.c
@@ -27,7 +27,7 @@ struct gbphy_host {
static DEFINE_IDA(gbphy_id);

static ssize_t protocol_id_show(struct device *dev,
- struct device_attribute *attr, char *buf)
+ struct device_attribute *attr, char *buf)
{
struct gbphy_device *gbphy_dev = to_gbphy_dev(dev);

@@ -221,7 +221,7 @@ void gb_gbphy_deregister_driver(struct gbphy_driver *driver)
EXPORT_SYMBOL_GPL(gb_gbphy_deregister_driver);

static struct gbphy_device *gb_gbphy_create_dev(struct gb_bundle *bundle,
- struct greybus_descriptor_cport *cport_desc)
+ struct greybus_descriptor_cport *cport_desc)
{
struct gbphy_device *gbphy_dev;
int retval;
--
2.17.1

2021-05-19 20:14:57

by Greg Kroah-Hartman

Subject: Re: [PATCH] Staging: greybus: fix open parenthesis issue in gbphy.c

On Wed, May 19, 2021 at 08:48:51PM +0530, F.A.Sulaiman wrote:
> This fix "Alignment should match open parenthesis" checkpatch error.
>
> Signed-off-by: "F.A.Sulaiman" <[email protected]>
> ---
> drivers/staging/greybus/gbphy.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/greybus/gbphy.c b/drivers/staging/greybus/gbphy.c
> index 9fc5c47be9bd..13d319860da5 100644
> --- a/drivers/staging/greybus/gbphy.c
> +++ b/drivers/staging/greybus/gbphy.c
> @@ -27,7 +27,7 @@ struct gbphy_host {
> static DEFINE_IDA(gbphy_id);
>
> static ssize_t protocol_id_show(struct device *dev,
> - struct device_attribute *attr, char *buf)
> + struct device_attribute *attr, char *buf)
> {
> struct gbphy_device *gbphy_dev = to_gbphy_dev(dev);
>
> @@ -221,7 +221,7 @@ void gb_gbphy_deregister_driver(struct gbphy_driver *driver)
> EXPORT_SYMBOL_GPL(gb_gbphy_deregister_driver);
>
> static struct gbphy_device *gb_gbphy_create_dev(struct gb_bundle *bundle,
> - struct greybus_descriptor_cport *cport_desc)
> + struct greybus_descriptor_cport *cport_desc)
> {
> struct gbphy_device *gbphy_dev;
> int retval;
> --
> 2.17.1
>
>

You sent this 3 different times, why?

Please send a new version, a v2, and say what changed from the previous
one.

thanks,

greg k-h