2021-05-12 08:12:59

by Sibi Sankar

Subject: [PATCH v3 1/2] cpufreq: blacklist SC7280 in cpufreq-dt-platdev

Add SC7280 to cpufreq-dt-platdev blacklist since the actual scaling is
handled by the 'qcom-cpufreq-hw' driver.

Reviewed-by: Douglas Anderson <[email protected]>
Signed-off-by: Sibi Sankar <[email protected]>
---
drivers/cpufreq/cpufreq-dt-platdev.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
index 5e07065ec22f..345418b8250e 100644
--- a/drivers/cpufreq/cpufreq-dt-platdev.c
+++ b/drivers/cpufreq/cpufreq-dt-platdev.c
@@ -137,6 +137,7 @@ static const struct of_device_id blacklist[] __initconst = {
{ .compatible = "qcom,msm8996", },
{ .compatible = "qcom,qcs404", },
{ .compatible = "qcom,sc7180", },
+ { .compatible = "qcom,sc7280", },
{ .compatible = "qcom,sdm845", },

{ .compatible = "st,stih407", },
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

2021-05-20 03:59:20

by Viresh Kumar

Subject: Re: [PATCH v3 1/2] cpufreq: blacklist SC7280 in cpufreq-dt-platdev

On 12-05-21, 13:41, Sibi Sankar wrote:
> Add SC7280 to cpufreq-dt-platdev blacklist since the actual scaling is
> handled by the 'qcom-cpufreq-hw' driver.
>
> Reviewed-by: Douglas Anderson <[email protected]>
> Signed-off-by: Sibi Sankar <[email protected]>
> ---
> drivers/cpufreq/cpufreq-dt-platdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
> index 5e07065ec22f..345418b8250e 100644
> --- a/drivers/cpufreq/cpufreq-dt-platdev.c
> +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
> @@ -137,6 +137,7 @@ static const struct of_device_id blacklist[] __initconst = {
> { .compatible = "qcom,msm8996", },
> { .compatible = "qcom,qcs404", },
> { .compatible = "qcom,sc7180", },
> + { .compatible = "qcom,sc7280", },
> { .compatible = "qcom,sdm845", },
>
> { .compatible = "st,stih407", },

Applied 1/2. Thanks.

What do you want to do for 2/2 ? Go through my tree? need an update ?

--
viresh

2021-05-20 07:24:28

by Sibi Sankar

Subject: Re: [PATCH v3 1/2] cpufreq: blacklist SC7280 in cpufreq-dt-platdev

On 2021-05-20 09:26, Viresh Kumar wrote:
> On 12-05-21, 13:41, Sibi Sankar wrote:
>> Add SC7280 to cpufreq-dt-platdev blacklist since the actual scaling is
>> handled by the 'qcom-cpufreq-hw' driver.
>>
>> Reviewed-by: Douglas Anderson <[email protected]>
>> Signed-off-by: Sibi Sankar <[email protected]>
>> ---
>> drivers/cpufreq/cpufreq-dt-platdev.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c
>> b/drivers/cpufreq/cpufreq-dt-platdev.c
>> index 5e07065ec22f..345418b8250e 100644
>> --- a/drivers/cpufreq/cpufreq-dt-platdev.c
>> +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
>> @@ -137,6 +137,7 @@ static const struct of_device_id blacklist[]
>> __initconst = {
>> { .compatible = "qcom,msm8996", },
>> { .compatible = "qcom,qcs404", },
>> { .compatible = "qcom,sc7180", },
>> + { .compatible = "qcom,sc7280", },
>> { .compatible = "qcom,sdm845", },
>>
>> { .compatible = "st,stih407", },
>
> Applied 1/2. Thanks.
>
> What do you want to do for 2/2 ? Go through my tree? need an update ?

Lets skip pulling in 2/2 for now. It depends
on a few other changes to land first and the
cpufreq node for sc7280 needs a re-spin.

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.

2021-05-31 18:23:52

by Bjorn Andersson

Subject: Re: [PATCH v3 1/2] cpufreq: blacklist SC7280 in cpufreq-dt-platdev

On Thu 20 May 02:20 CDT 2021, Sibi Sankar wrote:

> On 2021-05-20 09:26, Viresh Kumar wrote:
> > On 12-05-21, 13:41, Sibi Sankar wrote:
> > > Add SC7280 to cpufreq-dt-platdev blacklist since the actual scaling is
> > > handled by the 'qcom-cpufreq-hw' driver.
> > >
> > > Reviewed-by: Douglas Anderson <[email protected]>
> > > Signed-off-by: Sibi Sankar <[email protected]>
> > > ---
> > > drivers/cpufreq/cpufreq-dt-platdev.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c
> > > b/drivers/cpufreq/cpufreq-dt-platdev.c
> > > index 5e07065ec22f..345418b8250e 100644
> > > --- a/drivers/cpufreq/cpufreq-dt-platdev.c
> > > +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
> > > @@ -137,6 +137,7 @@ static const struct of_device_id blacklist[]
> > > __initconst = {
> > > { .compatible = "qcom,msm8996", },
> > > { .compatible = "qcom,qcs404", },
> > > { .compatible = "qcom,sc7180", },
> > > + { .compatible = "qcom,sc7280", },
> > > { .compatible = "qcom,sdm845", },
> > >
> > > { .compatible = "st,stih407", },
> >
> > Applied 1/2. Thanks.
> >
> > What do you want to do for 2/2 ? Go through my tree? need an update ?
>
> Lets skip pulling in 2/2 for now.

In particular it's ripe for merge conflicts, so I'd prefer to take it
through my tree.

> It depends on a few other changes to land first and the cpufreq node
> for sc7280 needs a re-spin.

What other dependencies do we have?

I dropped the reg-names from the cpufreq node and merged that change.

Regards,
Bjorn

2021-06-02 04:16:42

by Sibi Sankar

Subject: Re: [PATCH v3 1/2] cpufreq: blacklist SC7280 in cpufreq-dt-platdev

On 2021-05-31 23:51, Bjorn Andersson wrote:
> On Thu 20 May 02:20 CDT 2021, Sibi Sankar wrote:
>
>> On 2021-05-20 09:26, Viresh Kumar wrote:
>> > On 12-05-21, 13:41, Sibi Sankar wrote:
>> > > Add SC7280 to cpufreq-dt-platdev blacklist since the actual scaling is
>> > > handled by the 'qcom-cpufreq-hw' driver.
>> > >
>> > > Reviewed-by: Douglas Anderson <[email protected]>
>> > > Signed-off-by: Sibi Sankar <[email protected]>
>> > > ---
>> > > drivers/cpufreq/cpufreq-dt-platdev.c | 1 +
>> > > 1 file changed, 1 insertion(+)
>> > >
>> > > diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c
>> > > b/drivers/cpufreq/cpufreq-dt-platdev.c
>> > > index 5e07065ec22f..345418b8250e 100644
>> > > --- a/drivers/cpufreq/cpufreq-dt-platdev.c
>> > > +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
>> > > @@ -137,6 +137,7 @@ static const struct of_device_id blacklist[]
>> > > __initconst = {
>> > > { .compatible = "qcom,msm8996", },
>> > > { .compatible = "qcom,qcs404", },
>> > > { .compatible = "qcom,sc7180", },
>> > > + { .compatible = "qcom,sc7280", },
>> > > { .compatible = "qcom,sdm845", },
>> > >
>> > > { .compatible = "st,stih407", },
>> >
>> > Applied 1/2. Thanks.
>> >
>> > What do you want to do for 2/2 ? Go through my tree? need an update ?
>>
>> Lets skip pulling in 2/2 for now.
>
> In particular it's ripe for merge conflicts, so I'd prefer to take it
> through my tree.
>
>> It depends on a few other changes to land first and the cpufreq node
>> for sc7280 needs a re-spin.
>
> What other dependencies do we have?
>
> I dropped the reg-names from the cpufreq node and merged that change.

It depends on the epss cpufreq and l3 node.
The reg regions used by the cpufreq and
l3 regions currently overlap and that needs
to be sorted out in cpufreq.

>
> Regards,
> Bjorn

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.