2021-05-20 08:32:12

by Yue Hu

Subject: [PATCH] mmc: core: Use ternery for return value in mmc_vdd_to_ocrbitnum()

From: Yue Hu <[email protected]>

Just simplify the code.

Signed-off-by: Yue Hu <[email protected]>
---
drivers/mmc/core/core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
index f194940..600543c 100644
--- a/drivers/mmc/core/core.c
+++ b/drivers/mmc/core/core.c
@@ -1028,9 +1028,7 @@ static int mmc_vdd_to_ocrbitnum(int vdd, bool low_bits)

/* Base 2000 mV, step 100 mV, bit's base 8. */
bit = (vdd - 2000) / 100 + 8;
- if (bit > max_bit)
- return max_bit;
- return bit;
+ return (bit > max_bit) ? max_bit : bit;
}

/**
--
1.9.1

2021-05-24 11:44:33

by Christoph Hellwig

Subject: Re: [PATCH] mmc: core: Use ternery for return value in mmc_vdd_to_ocrbitnum()

On Thu, May 20, 2021 at 04:28:37PM +0800, Yue Hu wrote:
> From: Yue Hu <[email protected]>
>
> Just simplify the code.

The original version is way easier to read.