2021-05-21 03:37:49

by Lee Jones

Subject: [PATCH 36/38] drm/amd/amdgpu/vcn_v1_0: Fix some function naming disparity

Fixes the following W=1 kernel build warning(s):

drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:775: warning: expecting prototype for vcn_v1_0_start(). Prototype was for vcn_v1_0_start_spg_mode() instead
drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:1111: warning: expecting prototype for vcn_v1_0_stop(). Prototype was for vcn_v1_0_stop_spg_mode() instead

Cc: Alex Deucher <[email protected]>
Cc: "Christian König" <[email protected]>
Cc: David Airlie <[email protected]>
Cc: Daniel Vetter <[email protected]>
Cc: [email protected]
Cc: [email protected]
Signed-off-by: Lee Jones <[email protected]>
---
drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c
index 0c1beefa3e498..2c9af18683feb 100644
--- a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c
@@ -765,7 +765,7 @@ static void vcn_1_0_enable_static_power_gating(struct amdgpu_device *adev)
}

/**
- * vcn_v1_0_start - start VCN block
+ * vcn_v1_0_start_spg_mode - start VCN block
*
* @adev: amdgpu_device pointer
*
@@ -1101,7 +1101,7 @@ static int vcn_v1_0_start(struct amdgpu_device *adev)
}

/**
- * vcn_v1_0_stop - stop VCN block
+ * vcn_v1_0_stop_spg_mode - stop VCN block
*
* @adev: amdgpu_device pointer
*
--
2.31.1

2021-05-21 16:55:24

by Alex Deucher

Subject: Re: [PATCH 36/38] drm/amd/amdgpu/vcn_v1_0: Fix some function naming disparity

Applied. Thanks!

On Thu, May 20, 2021 at 8:03 AM Lee Jones <[email protected]> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:775: warning: expecting prototype for vcn_v1_0_start(). Prototype was for vcn_v1_0_start_spg_mode() instead
> drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:1111: warning: expecting prototype for vcn_v1_0_stop(). Prototype was for vcn_v1_0_stop_spg_mode() instead
>
> Cc: Alex Deucher <[email protected]>
> Cc: "Christian König" <[email protected]>
> Cc: David Airlie <[email protected]>
> Cc: Daniel Vetter <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Signed-off-by: Lee Jones <[email protected]>
> ---
> drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c
> index 0c1beefa3e498..2c9af18683feb 100644
> --- a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c
> @@ -765,7 +765,7 @@ static void vcn_1_0_enable_static_power_gating(struct amdgpu_device *adev)
> }
>
> /**
> - * vcn_v1_0_start - start VCN block
> + * vcn_v1_0_start_spg_mode - start VCN block
> *
> * @adev: amdgpu_device pointer
> *
> @@ -1101,7 +1101,7 @@ static int vcn_v1_0_start(struct amdgpu_device *adev)
> }
>
> /**
> - * vcn_v1_0_stop - stop VCN block
> + * vcn_v1_0_stop_spg_mode - stop VCN block
> *
> * @adev: amdgpu_device pointer
> *
> --
> 2.31.1
>