2021-05-21 09:38:50

by Austin Kim

Subject: [PATCH] drm/msm/dpu: remove unused variable cmd_enc

After the call to to_dpu_encoder_phys_cmd() is made,
'cmd_enc' is not used. Where to_dpu_encoder_phys_cmd() is simply replaced with
container_of(x, struct dpu_encoder_phys_cmd, base) by compiler.

So it had better remove W=1 kernel build warning(s):

drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c: In function
‘dpu_encoder_phys_cmd_wait_for_commit_done’:
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c:688:31: warning:
variable ‘cmd_enc’ set but not used

Signed-off-by: Austin Kim <[email protected]>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
index b2be39b9144e..088900841bf8 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
@@ -685,10 +685,6 @@ static int dpu_encoder_phys_cmd_wait_for_tx_complete(
static int dpu_encoder_phys_cmd_wait_for_commit_done(
struct dpu_encoder_phys *phys_enc)
{
- struct dpu_encoder_phys_cmd *cmd_enc;
-
- cmd_enc = to_dpu_encoder_phys_cmd(phys_enc);
-
/* only required for master controller */
if (!dpu_encoder_phys_cmd_is_master(phys_enc))
return 0;
--
2.20.1

2021-05-27 05:52:07

by Austin Kim

Subject: Re: [PATCH] drm/msm/dpu: remove unused variable cmd_enc

2021년 5월 21일 (금) 오후 1:16, Austin Kim <[email protected]>님이 작성:
>
> After the call to to_dpu_encoder_phys_cmd() is made,
> 'cmd_enc' is not used. Where to_dpu_encoder_phys_cmd() is simply replaced with
> container_of(x, struct dpu_encoder_phys_cmd, base) by compiler.
>
> So it had better remove W=1 kernel build warning(s):
>
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c: In function
> ‘dpu_encoder_phys_cmd_wait_for_commit_done’:
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c:688:31: warning:
> variable ‘cmd_enc’ set but not used
>
> Signed-off-by: Austin Kim <[email protected]>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
> index b2be39b9144e..088900841bf8 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
> @@ -685,10 +685,6 @@ static int dpu_encoder_phys_cmd_wait_for_tx_complete(
> static int dpu_encoder_phys_cmd_wait_for_commit_done(
> struct dpu_encoder_phys *phys_enc)
> {
> - struct dpu_encoder_phys_cmd *cmd_enc;
> -
> - cmd_enc = to_dpu_encoder_phys_cmd(phys_enc);
> -
> /* only required for master controller */
> if (!dpu_encoder_phys_cmd_is_master(phys_enc))
> return 0;
> --
> 2.20.1
>

If you are available, would you please review this patch.

BR,
Austin Kim