2021-05-21 13:45:33

by Etienne Carriere

[permalink] [raw]
Subject: [PATCH v2 2/4] dt-bindings: arm: scmi property mboxes is not mandatory

Since "arm,scmi-smc" compatible support, mboxes property is not mandated.
This change fixes the DT bindings description accordingly.

Cc: Rob Herring <[email protected]>
Cc: [email protected]
Signed-off-by: Etienne Carriere <[email protected]>
---
Changes since v1:
- New patch is the series. Addresses mboxes propery description.
---
Documentation/devicetree/bindings/arm/arm,scmi.txt | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/arm,scmi.txt b/Documentation/devicetree/bindings/arm/arm,scmi.txt
index 667d58e0a659..856d041b397e 100644
--- a/Documentation/devicetree/bindings/arm/arm,scmi.txt
+++ b/Documentation/devicetree/bindings/arm/arm,scmi.txt
@@ -15,10 +15,10 @@ Required properties:
The scmi node with the following properties shall be under the /firmware/ node.

- compatible : shall be "arm,scmi" or "arm,scmi-smc" for smc/hvc transports
-- mboxes: List of phandle and mailbox channel specifiers. It should contain
- exactly one or two mailboxes, one for transmitting messages("tx")
- and another optional for receiving the notifications("rx") if
- supported.
+- mboxes: List of phandle and mailbox channel specifiers. When used, it should
+ contain exactly one or two mailboxes, one for transmitting messages
+ ("tx") and another optional for receiving the notifications("rx") if
+ supported. Mandated by compatible "arm,scmi".
- shmem : List of phandle pointing to the shared memory(SHM) area as per
generic mailbox client binding.
- #address-cells : should be '1' if the device has sub-nodes, maps to
--
2.17.1


2021-06-02 10:42:51

by Sudeep Holla

[permalink] [raw]
Subject: Re: [PATCH v2 2/4] dt-bindings: arm: scmi property mboxes is not mandatory

On Fri, May 21, 2021 at 03:40:52PM +0200, Etienne Carriere wrote:
> Since "arm,scmi-smc" compatible support, mboxes property is not mandated.
> This change fixes the DT bindings description accordingly.
>
> Cc: Rob Herring <[email protected]>
> Cc: [email protected]
> Signed-off-by: Etienne Carriere <[email protected]>
> ---
> Changes since v1:
> - New patch is the series. Addresses mboxes propery description.
> ---
> Documentation/devicetree/bindings/arm/arm,scmi.txt | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/arm,scmi.txt b/Documentation/devicetree/bindings/arm/arm,scmi.txt
> index 667d58e0a659..856d041b397e 100644
> --- a/Documentation/devicetree/bindings/arm/arm,scmi.txt
> +++ b/Documentation/devicetree/bindings/arm/arm,scmi.txt
> @@ -15,10 +15,10 @@ Required properties:
> The scmi node with the following properties shall be under the /firmware/ node.
>
> - compatible : shall be "arm,scmi" or "arm,scmi-smc" for smc/hvc transports
> -- mboxes: List of phandle and mailbox channel specifiers. It should contain
> - exactly one or two mailboxes, one for transmitting messages("tx")
> - and another optional for receiving the notifications("rx") if
> - supported.
> +- mboxes: List of phandle and mailbox channel specifiers. When used, it should
> + contain exactly one or two mailboxes, one for transmitting messages
> + ("tx") and another optional for receiving the notifications("rx") if
> + supported. Mandated by compatible "arm,scmi".

This change is not required with yaml as you can have right schema to reflect
this dependency. I think I already took care of this.

--
Regards,
Sudeep