2021-05-25 05:48:26

by Oleksij Rempel

[permalink] [raw]
Subject: [PATCH v6 0/4] add z1 and z2 channels support for resistive-adc-touch driver

changes v6:
- drop other DT changes
- add more Reviewed-by tags
- remove redundant GRTS_CH_NONE check

changes v5:
- fix validate for other DT examples.
- add Reviewed-by: Rob Herring <[email protected]> to some of the patches

changes v4:
- resistive-adc-touch: remove unused variable

changes v3:
- yaml: fix validation for channel names
- yaml: add nodename validation

changes v2:
- add yaml conversion patch to this series
- reword commit message for the last patch
- fix possible overflow on the buffer dispatcher

Oleksij Rempel (4):
dt-bindings: touchscreen: Convert resistive-adc-touch binding to json
schema
dt-bindings: touchscreen: add touchscreen-x/y-plate-ohms property
dt-bindings: touchscreen: resistive-adc-touch: add support for z1 and
z2 channels
Input: resistive-adc-touch: add support for z1 and z2 channels

.../input/touchscreen/resistive-adc-touch.txt | 33 -----
.../touchscreen/resistive-adc-touch.yaml | 86 +++++++++++
.../input/touchscreen/touchscreen.yaml | 6 +
.../input/touchscreen/resistive-adc-touch.c | 140 ++++++++++++++++--
4 files changed, 218 insertions(+), 47 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/input/touchscreen/resistive-adc-touch.txt
create mode 100644 Documentation/devicetree/bindings/input/touchscreen/resistive-adc-touch.yaml

--
2.29.2


2021-05-25 05:49:46

by Oleksij Rempel

[permalink] [raw]
Subject: [PATCH v6 2/4] dt-bindings: touchscreen: add touchscreen-x/y-plate-ohms property

Te calculate the pressure on a restrictive touchscreen we need need to
know resistance at least of X plate. Some calculations need to use both
X and Y values.
So, add generic properties which can be used by all drivers

Signed-off-by: Oleksij Rempel <[email protected]>
Reviewed-by: Rob Herring <[email protected]>
---
.../devicetree/bindings/input/touchscreen/touchscreen.yaml | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml b/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml
index 057e1063759c..2d7b039ce47f 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml
+++ b/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml
@@ -77,6 +77,12 @@ properties:
touchscreen-y-mm:
description: vertical length in mm of the touchscreen

+ touchscreen-x-plate-ohms:
+ description: Resistance of the X-plate in Ohms
+
+ touchscreen-y-plate-ohms:
+ description: Resistance of the Y-plate in Ohms
+
dependencies:
touchscreen-size-x: [ touchscreen-size-y ]
touchscreen-size-y: [ touchscreen-size-x ]
--
2.29.2

2021-05-25 22:30:08

by Dmitry Torokhov

[permalink] [raw]
Subject: Re: [PATCH v6 0/4] add z1 and z2 channels support for resistive-adc-touch driver

Hi Oleksij,

On Tue, May 25, 2021 at 07:46:30AM +0200, Oleksij Rempel wrote:
> changes v6:
> - drop other DT changes
> - add more Reviewed-by tags
> - remove redundant GRTS_CH_NONE check

Applied the lot, thank you.

--
Dmitry

2021-06-07 09:24:09

by Oleksij Rempel

[permalink] [raw]
Subject: Re: [PATCH v6 0/4] add z1 and z2 channels support for resistive-adc-touch driver

Hello Eugen,

On Wed, Jun 02, 2021 at 11:15:47AM +0000, [email protected] wrote:
> On 5/25/21 8:46 AM, Oleksij Rempel wrote:
> > changes v6:
> > - drop other DT changes
> > - add more Reviewed-by tags
> > - remove redundant GRTS_CH_NONE check
> >
> > changes v5:
> > - fix validate for other DT examples.
> > - add Reviewed-by: Rob Herring <[email protected]> to some of the patches
> >
> > changes v4:
> > - resistive-adc-touch: remove unused variable
> >
> > changes v3:
> > - yaml: fix validation for channel names
> > - yaml: add nodename validation
> >
> > changes v2:
> > - add yaml conversion patch to this series
> > - reword commit message for the last patch
> > - fix possible overflow on the buffer dispatcher
> >
> > Oleksij Rempel (4):
> > dt-bindings: touchscreen: Convert resistive-adc-touch binding to json
> > schema
> > dt-bindings: touchscreen: add touchscreen-x/y-plate-ohms property
> > dt-bindings: touchscreen: resistive-adc-touch: add support for z1 and
> > z2 channels
> > Input: resistive-adc-touch: add support for z1 and z2 channels
> >
> > .../input/touchscreen/resistive-adc-touch.txt | 33 -----
> > .../touchscreen/resistive-adc-touch.yaml | 86 +++++++++++
> > .../input/touchscreen/touchscreen.yaml | 6 +
> > .../input/touchscreen/resistive-adc-touch.c | 140 ++++++++++++++++--
> > 4 files changed, 218 insertions(+), 47 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/input/touchscreen/resistive-adc-touch.txt
> > create mode 100644 Documentation/devicetree/bindings/input/touchscreen/resistive-adc-touch.yaml
> >
> > --
> > 2.29.2
> >
>
>
>
> Hello Oleksij,
>
> As I am listed in the MAINTAINERS file for this driver, why I am not
> even CC-ed to this patch series ?

Sorry, I missed you by accident.
Beside, you are not listed as maintainer for the:
Documentation/devicetree/bindings/input/touchscreen/resistive-adc-touch.*

> At least what I could have done is test this series on my board using
> this driver.

Do you have some regressions with it?

Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |