2021-05-25 12:44:12

by Axel Lin

[permalink] [raw]
Subject: [PATCH 1/2] regulator: fan53555: Fix missing slew_reg/mask/shift settings for FAN53526

The di->slew_reg/di->slew_mask/di->slew_shift was not set in current code,
fix it.

Fixes: f2a9eb975ab2 ("regulator: fan53555: Add support for FAN53526")
Signed-off-by: Axel Lin <[email protected]>
---
drivers/regulator/fan53555.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/regulator/fan53555.c b/drivers/regulator/fan53555.c
index f3f49cf3731b..9770a4df83d4 100644
--- a/drivers/regulator/fan53555.c
+++ b/drivers/regulator/fan53555.c
@@ -296,6 +296,9 @@ static int fan53526_voltages_setup_fairchild(struct fan53555_device_info *di)
return -EINVAL;
}

+ di->slew_reg = FAN53555_CONTROL;
+ di->slew_mask = CTL_SLEW_MASK;
+ di->slew_shift = CTL_SLEW_SHIFT;
di->vsel_count = FAN53526_NVOLTAGES;

return 0;
--
2.25.1


2021-06-03 18:46:45

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH 1/2] regulator: fan53555: Fix missing slew_reg/mask/shift settings for FAN53526

On Tue, 25 May 2021 20:40:16 +0800, Axel Lin wrote:
> The di->slew_reg/di->slew_mask/di->slew_shift was not set in current code,
> fix it.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/2] regulator: fan53555: Fix missing slew_reg/mask/shift settings for FAN53526
commit: 30b38b805b36c03db3703ef62397111c783b5f3b
[2/2] regulator: fan53555: Convert to use regulator_set_ramp_delay_regmap
commit: b61ac767db4d62540732cdac9f1820e56b9a5008

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark