This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
Lee Jones (10):
bus: fsl-mc: mc-io: Supply function names for 'fsl_create_mc_io()' and
'fsl_destroy_mc_io()'
bus: fsl-mc: mc-sys: Supply missing function names in kernel-doc
headers
bus: fsl-mc: fsl-mc-bus: Demote a bunch of non-conformant kernel-doc
headers and help others
bus: fsl-mc: dprc: Fix a couple of misspelling and formatting issues
bus: fsl-mc: dprc-driver: Fix some missing/incorrect function
parameter descriptions
bus: fsl-mc: fsl-mc-allocator: Fix misspelling of 'new_mc_adev' and
demote non-kernel-doc headers
bus: qcom-ebi2: Fix incorrect documentation for '{slow,fast}_cfg'
bus: fsl-mc-msi: Fix a little doc-rot pertaining to 'np' to 'fwnode'
conversion
bus: ti-sysc: Correct misdocumentation of 'sysc_ioremap()'
bus: fsl-mc: mc-io: Correct misdocumentation of 'dpmcp_dev' param
drivers/bus/fsl-mc/dprc-driver.c | 8 +++++---
drivers/bus/fsl-mc/dprc.c | 4 ++--
drivers/bus/fsl-mc/fsl-mc-allocator.c | 10 +++++-----
drivers/bus/fsl-mc/fsl-mc-bus.c | 19 ++++++++++---------
drivers/bus/fsl-mc/fsl-mc-msi.c | 2 +-
drivers/bus/fsl-mc/mc-io.c | 6 +++---
drivers/bus/fsl-mc/mc-sys.c | 19 ++++++++++---------
drivers/bus/qcom-ebi2.c | 4 ++--
drivers/bus/ti-sysc.c | 2 +-
9 files changed, 39 insertions(+), 35 deletions(-)
Cc: Andy Gross <[email protected]>
Cc: Bjorn Andersson <[email protected]>
Cc: German Rivera <[email protected]>
Cc: Laurentiu Tudor <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: Philipp Zabel <[email protected]>
Cc: Stuart Yoder <[email protected]>
Cc: Tony Lindgren <[email protected]>
--
2.31.1
Fixes the following W=1 kernel build warning(s):
drivers/bus/fsl-mc/dprc-driver.c:360: warning: Function parameter or member 'alloc_interrupts' not described in 'dprc_scan_container'
drivers/bus/fsl-mc/dprc-driver.c:383: warning: Function parameter or member 'irq_num' not described in 'dprc_irq0_handler'
drivers/bus/fsl-mc/dprc-driver.c:383: warning: Excess function parameter 'irq' description in 'dprc_irq0_handler'
drivers/bus/fsl-mc/dprc-driver.c:394: warning: Function parameter or member 'irq_num' not described in 'dprc_irq0_handler_thread'
drivers/bus/fsl-mc/dprc-driver.c:394: warning: Excess function parameter 'irq' description in 'dprc_irq0_handler_thread'
Cc: Stuart Yoder <[email protected]>
Cc: Laurentiu Tudor <[email protected]>
Cc: German Rivera <[email protected]>
Signed-off-by: Lee Jones <[email protected]>
---
drivers/bus/fsl-mc/dprc-driver.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/bus/fsl-mc/dprc-driver.c b/drivers/bus/fsl-mc/dprc-driver.c
index e3e2ae41c22b3..315e830b6ecda 100644
--- a/drivers/bus/fsl-mc/dprc-driver.c
+++ b/drivers/bus/fsl-mc/dprc-driver.c
@@ -350,7 +350,8 @@ int dprc_scan_objects(struct fsl_mc_device *mc_bus_dev,
* dprc_scan_container - Scans a physical DPRC and synchronizes Linux bus state
*
* @mc_bus_dev: pointer to the fsl-mc device that represents a DPRC object
- *
+ * @alloc_interrupts: if true the function allocates the interrupt pool,
+ * otherwise the interrupt allocation is delayed
* Scans the physical DPRC and synchronizes the state of the Linux
* bus driver with the actual state of the MC by adding and removing
* devices as appropriate.
@@ -373,10 +374,11 @@ int dprc_scan_container(struct fsl_mc_device *mc_bus_dev,
return error;
}
EXPORT_SYMBOL_GPL(dprc_scan_container);
+
/**
* dprc_irq0_handler - Regular ISR for DPRC interrupt 0
*
- * @irq: IRQ number of the interrupt being handled
+ * @irq_num: IRQ number of the interrupt being handled
* @arg: Pointer to device structure
*/
static irqreturn_t dprc_irq0_handler(int irq_num, void *arg)
@@ -387,7 +389,7 @@ static irqreturn_t dprc_irq0_handler(int irq_num, void *arg)
/**
* dprc_irq0_handler_thread - Handler thread function for DPRC interrupt 0
*
- * @irq: IRQ number of the interrupt being handled
+ * @irq_num: IRQ number of the interrupt being handled
* @arg: Pointer to device structure
*/
static irqreturn_t dprc_irq0_handler_thread(int irq_num, void *arg)
--
2.31.1
Hi Lee,
On 5/26/2021 11:10 AM, Lee Jones wrote:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
>
> Lee Jones (10):
> bus: fsl-mc: mc-io: Supply function names for 'fsl_create_mc_io()' and
> 'fsl_destroy_mc_io()'
> bus: fsl-mc: mc-sys: Supply missing function names in kernel-doc
> headers
> bus: fsl-mc: fsl-mc-bus: Demote a bunch of non-conformant kernel-doc
> headers and help others
> bus: fsl-mc: dprc: Fix a couple of misspelling and formatting issues
> bus: fsl-mc: dprc-driver: Fix some missing/incorrect function
> parameter descriptions
> bus: fsl-mc: fsl-mc-allocator: Fix misspelling of 'new_mc_adev' and
> demote non-kernel-doc headers
> bus: qcom-ebi2: Fix incorrect documentation for '{slow,fast}_cfg'
> bus: fsl-mc-msi: Fix a little doc-rot pertaining to 'np' to 'fwnode'
> conversion
> bus: ti-sysc: Correct misdocumentation of 'sysc_ioremap()'
> bus: fsl-mc: mc-io: Correct misdocumentation of 'dpmcp_dev' param
>
> drivers/bus/fsl-mc/dprc-driver.c | 8 +++++---
> drivers/bus/fsl-mc/dprc.c | 4 ++--
> drivers/bus/fsl-mc/fsl-mc-allocator.c | 10 +++++-----
> drivers/bus/fsl-mc/fsl-mc-bus.c | 19 ++++++++++---------
> drivers/bus/fsl-mc/fsl-mc-msi.c | 2 +-
> drivers/bus/fsl-mc/mc-io.c | 6 +++---
> drivers/bus/fsl-mc/mc-sys.c | 19 ++++++++++---------
Thanks for this. For drivers/bus/fsl-mc/*:
Reviewed-by: Laurentiu Tudor <[email protected]>
---
Best Regards, Laurentiu
On Wed, 26 May 2021, Laurentiu Tudor wrote:
> Hi Lee,
>
> On 5/26/2021 11:10 AM, Lee Jones wrote:
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
> >
> > Lee Jones (10):
> > bus: fsl-mc: mc-io: Supply function names for 'fsl_create_mc_io()' and
> > 'fsl_destroy_mc_io()'
> > bus: fsl-mc: mc-sys: Supply missing function names in kernel-doc
> > headers
> > bus: fsl-mc: fsl-mc-bus: Demote a bunch of non-conformant kernel-doc
> > headers and help others
> > bus: fsl-mc: dprc: Fix a couple of misspelling and formatting issues
> > bus: fsl-mc: dprc-driver: Fix some missing/incorrect function
> > parameter descriptions
> > bus: fsl-mc: fsl-mc-allocator: Fix misspelling of 'new_mc_adev' and
> > demote non-kernel-doc headers
> > bus: qcom-ebi2: Fix incorrect documentation for '{slow,fast}_cfg'
> > bus: fsl-mc-msi: Fix a little doc-rot pertaining to 'np' to 'fwnode'
> > conversion
> > bus: ti-sysc: Correct misdocumentation of 'sysc_ioremap()'
> > bus: fsl-mc: mc-io: Correct misdocumentation of 'dpmcp_dev' param
> >
> > drivers/bus/fsl-mc/dprc-driver.c | 8 +++++---
> > drivers/bus/fsl-mc/dprc.c | 4 ++--
> > drivers/bus/fsl-mc/fsl-mc-allocator.c | 10 +++++-----
> > drivers/bus/fsl-mc/fsl-mc-bus.c | 19 ++++++++++---------
> > drivers/bus/fsl-mc/fsl-mc-msi.c | 2 +-
> > drivers/bus/fsl-mc/mc-io.c | 6 +++---
> > drivers/bus/fsl-mc/mc-sys.c | 19 ++++++++++---------
>
> Thanks for this. For drivers/bus/fsl-mc/*:
>
> Reviewed-by: Laurentiu Tudor <[email protected]>
Any idea who will take the 'fsl-mc' patches please?
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
On 6/17/2021 12:49 PM, Lee Jones wrote:
> On Wed, 26 May 2021, Laurentiu Tudor wrote:
>
>> Hi Lee,
>>
>> On 5/26/2021 11:10 AM, Lee Jones wrote:
>>> This set is part of a larger effort attempting to clean-up W=1
>>> kernel builds, which are currently overwhelmingly riddled with
>>> niggly little warnings.
>>>
>>> Lee Jones (10):
>>> bus: fsl-mc: mc-io: Supply function names for 'fsl_create_mc_io()' and
>>> 'fsl_destroy_mc_io()'
>>> bus: fsl-mc: mc-sys: Supply missing function names in kernel-doc
>>> headers
>>> bus: fsl-mc: fsl-mc-bus: Demote a bunch of non-conformant kernel-doc
>>> headers and help others
>>> bus: fsl-mc: dprc: Fix a couple of misspelling and formatting issues
>>> bus: fsl-mc: dprc-driver: Fix some missing/incorrect function
>>> parameter descriptions
>>> bus: fsl-mc: fsl-mc-allocator: Fix misspelling of 'new_mc_adev' and
>>> demote non-kernel-doc headers
>>> bus: qcom-ebi2: Fix incorrect documentation for '{slow,fast}_cfg'
>>> bus: fsl-mc-msi: Fix a little doc-rot pertaining to 'np' to 'fwnode'
>>> conversion
>>> bus: ti-sysc: Correct misdocumentation of 'sysc_ioremap()'
>>> bus: fsl-mc: mc-io: Correct misdocumentation of 'dpmcp_dev' param
>>>
>>> drivers/bus/fsl-mc/dprc-driver.c | 8 +++++---
>>> drivers/bus/fsl-mc/dprc.c | 4 ++--
>>> drivers/bus/fsl-mc/fsl-mc-allocator.c | 10 +++++-----
>>> drivers/bus/fsl-mc/fsl-mc-bus.c | 19 ++++++++++---------
>>> drivers/bus/fsl-mc/fsl-mc-msi.c | 2 +-
>>> drivers/bus/fsl-mc/mc-io.c | 6 +++---
>>> drivers/bus/fsl-mc/mc-sys.c | 19 ++++++++++---------
>>
>> Thanks for this. For drivers/bus/fsl-mc/*:
>>
>> Reviewed-by: Laurentiu Tudor <[email protected]>
>
> Any idea who will take the 'fsl-mc' patches please?
>
Usually GregKH (added in the thread) picks them up through his char-misc
tree.
---
Best Regards, Laurentiu
On Thu, Jun 17, 2021 at 01:11:39PM +0300, Laurentiu Tudor wrote:
>
>
> On 6/17/2021 12:49 PM, Lee Jones wrote:
> > On Wed, 26 May 2021, Laurentiu Tudor wrote:
> >
> >> Hi Lee,
> >>
> >> On 5/26/2021 11:10 AM, Lee Jones wrote:
> >>> This set is part of a larger effort attempting to clean-up W=1
> >>> kernel builds, which are currently overwhelmingly riddled with
> >>> niggly little warnings.
> >>>
> >>> Lee Jones (10):
> >>> bus: fsl-mc: mc-io: Supply function names for 'fsl_create_mc_io()' and
> >>> 'fsl_destroy_mc_io()'
> >>> bus: fsl-mc: mc-sys: Supply missing function names in kernel-doc
> >>> headers
> >>> bus: fsl-mc: fsl-mc-bus: Demote a bunch of non-conformant kernel-doc
> >>> headers and help others
> >>> bus: fsl-mc: dprc: Fix a couple of misspelling and formatting issues
> >>> bus: fsl-mc: dprc-driver: Fix some missing/incorrect function
> >>> parameter descriptions
> >>> bus: fsl-mc: fsl-mc-allocator: Fix misspelling of 'new_mc_adev' and
> >>> demote non-kernel-doc headers
> >>> bus: qcom-ebi2: Fix incorrect documentation for '{slow,fast}_cfg'
> >>> bus: fsl-mc-msi: Fix a little doc-rot pertaining to 'np' to 'fwnode'
> >>> conversion
> >>> bus: ti-sysc: Correct misdocumentation of 'sysc_ioremap()'
> >>> bus: fsl-mc: mc-io: Correct misdocumentation of 'dpmcp_dev' param
> >>>
> >>> drivers/bus/fsl-mc/dprc-driver.c | 8 +++++---
> >>> drivers/bus/fsl-mc/dprc.c | 4 ++--
> >>> drivers/bus/fsl-mc/fsl-mc-allocator.c | 10 +++++-----
> >>> drivers/bus/fsl-mc/fsl-mc-bus.c | 19 ++++++++++---------
> >>> drivers/bus/fsl-mc/fsl-mc-msi.c | 2 +-
> >>> drivers/bus/fsl-mc/mc-io.c | 6 +++---
> >>> drivers/bus/fsl-mc/mc-sys.c | 19 ++++++++++---------
> >>
> >> Thanks for this. For drivers/bus/fsl-mc/*:
> >>
> >> Reviewed-by: Laurentiu Tudor <[email protected]>
> >
> > Any idea who will take the 'fsl-mc' patches please?
> >
>
> Usually GregKH (added in the thread) picks them up through his char-misc
> tree.
If you resend just the fsl-mc patches as a series, I can pick them up
that way. Otherwise trying to pick out individual ones here is pretty
much impossible...
thanks,
greg k-h