2021-05-26 12:37:28

by Jiapeng Chong

Subject: [PATCH] drivers/net/sungem: Fix inconsistent indenting

Eliminate the follow smatch warning:

drivers/net/sungem_phy.c:412 genmii_read_link() warn: inconsistent
indenting.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/net/sungem_phy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/sungem_phy.c b/drivers/net/sungem_phy.c
index 291fa44..4daac5f 100644
--- a/drivers/net/sungem_phy.c
+++ b/drivers/net/sungem_phy.c
@@ -409,7 +409,7 @@ static int genmii_read_link(struct mii_phy *phy)
* though magic-aneg shouldn't prevent this case from occurring
*/

- return 0;
+ return 0;
}

static int generic_suspend(struct mii_phy* phy)
--
1.8.3.1

2021-05-27 03:13:32

by Jakub Kicinski

Subject: Re: [PATCH] drivers/net/sungem: Fix inconsistent indenting

On Wed, 26 May 2021 18:24:08 +0800 Jiapeng Chong wrote:
> Eliminate the follow smatch warning:
>
> drivers/net/sungem_phy.c:412 genmii_read_link() warn: inconsistent
> indenting.
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>
> ---
> drivers/net/sungem_phy.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/sungem_phy.c b/drivers/net/sungem_phy.c
> index 291fa44..4daac5f 100644
> --- a/drivers/net/sungem_phy.c
> +++ b/drivers/net/sungem_phy.c
> @@ -409,7 +409,7 @@ static int genmii_read_link(struct mii_phy *phy)
> * though magic-aneg shouldn't prevent this case from occurring
> */
>
> - return 0;
> + return 0;
> }
>
> static int generic_suspend(struct mii_phy* phy)

Do you have any statistics on how many such patches we'd need to apply
to make the kernel free for such warning? If it's too many it's probably
not worth it, this patch for example has net zero effect on readability.