2021-05-27 01:16:33

by Andre Przywara

[permalink] [raw]
Subject: Re: [PATCH v3] ARM: dts: sun8i: v3s: enable emac for zero Dock

On Tue, 25 May 2021 19:31:59 +0200
Andreas Rehn <[email protected]> wrote:

> dwmac-sun8i supports v3s and
> Licheepi-zero Dock provides an ethernet port
> furthermore, align nodes in alphabetical order
>
> Signed-off-by: Andreas Rehn <[email protected]>

Reviewed-by: Andre Przywara <[email protected]>

Cheers,
Andre

> ---
> Changes in v3:
> - align nodes in alphabetical order
> Changes in v2:
> - add ethernet0 alias.
> .../boot/dts/sun8i-v3s-licheepi-zero-dock.dts | 17 +++++++++++++----
> 1 file changed, 13 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts
> index db5cd0b8574b..752ad05c8f83 100644
> --- a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts
> +++ b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts
> @@ -49,16 +49,18 @@ / {
> compatible = "licheepi,licheepi-zero-dock", "licheepi,licheepi-zero",
> "allwinner,sun8i-v3s";
>
> + aliases {
> + ethernet0 = &emac;
> + };
> +
> leds {
> /* The LEDs use PG0~2 pins, which conflict with MMC1 */
> status = "disabled";
> };
> };
>
> -&mmc1 {
> - broken-cd;
> - bus-width = <4>;
> - vmmc-supply = <&reg_vcc3v3>;
> +&emac {
> + allwinner,leds-active-low;
> status = "okay";
> };
>
> @@ -94,3 +96,10 @@ button-800 {
> voltage = <800000>;
> };
> };
> +
> +&mmc1 {
> + broken-cd;
> + bus-width = <4>;
> + vmmc-supply = <&reg_vcc3v3>;
> + status = "okay";
> +};


2021-05-31 09:48:04

by Maxime Ripard

[permalink] [raw]
Subject: Re: [PATCH v3] ARM: dts: sun8i: v3s: enable emac for zero Dock

On Thu, May 27, 2021 at 12:16:14AM +0100, Andre Przywara wrote:
> On Tue, 25 May 2021 19:31:59 +0200
> Andreas Rehn <[email protected]> wrote:
>
> > dwmac-sun8i supports v3s and
> > Licheepi-zero Dock provides an ethernet port
> > furthermore, align nodes in alphabetical order
> >
> > Signed-off-by: Andreas Rehn <[email protected]>
>
> Reviewed-by: Andre Przywara <[email protected]>

Applied, thanks
Maxime


Attachments:
(No filename) (446.00 B)
signature.asc (235.00 B)
Download all attachments