2021-05-28 17:20:21

by Kai-Heng Feng

Subject: [PATCH] PCI: Add const type for comparison function parameter

Commit 4f0f586bf0c8 ("treewide: Change list_sort to use const pointers")
added const on parameter "struct list_head *".

So add const to match the type.

Fixes: 276b15de5287 ("PCI: Coalesce host bridge contiguous apertures")
Reported-by: kernel test robot <[email protected]>
Signed-off-by: Kai-Heng Feng <[email protected]>
---
drivers/pci/probe.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
index bf58e5dd1d82..bd862b612633 100644
--- a/drivers/pci/probe.c
+++ b/drivers/pci/probe.c
@@ -875,7 +875,8 @@ static void pci_set_bus_msi_domain(struct pci_bus *bus)
dev_set_msi_domain(&bus->dev, d);
}

-static int res_cmp(void *priv, struct list_head *a, struct list_head *b)
+static int res_cmp(void *priv, const struct list_head *a,
+ const struct list_head *b)
{
struct resource_entry *entry1, *entry2;

--
2.31.1

2021-05-28 19:22:44

by Bjorn Helgaas

Subject: Re: [PATCH] PCI: Add const type for comparison function parameter

On Sat, May 29, 2021 at 01:02:42AM +0800, Kai-Heng Feng wrote:
> Commit 4f0f586bf0c8 ("treewide: Change list_sort to use const pointers")
> added const on parameter "struct list_head *".
>
> So add const to match the type.
>
> Fixes: 276b15de5287 ("PCI: Coalesce host bridge contiguous apertures")
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Kai-Heng Feng <[email protected]>

Squashed into "PCI: Coalesce host bridge contiguous apertures",
thanks!

> ---
> drivers/pci/probe.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
> index bf58e5dd1d82..bd862b612633 100644
> --- a/drivers/pci/probe.c
> +++ b/drivers/pci/probe.c
> @@ -875,7 +875,8 @@ static void pci_set_bus_msi_domain(struct pci_bus *bus)
> dev_set_msi_domain(&bus->dev, d);
> }
>
> -static int res_cmp(void *priv, struct list_head *a, struct list_head *b)
> +static int res_cmp(void *priv, const struct list_head *a,
> + const struct list_head *b)
> {
> struct resource_entry *entry1, *entry2;
>
> --
> 2.31.1
>