2021-05-29 11:52:12

by Yue Haibing

Subject: [PATCH -next] cifs: Remove unused inline function is_sysvol_or_netlogon()

is_sysvol_or_netlogon() is never used, so can remove it.

Signed-off-by: YueHaibing <[email protected]>
---
fs/cifs/dfs_cache.c | 11 -----------
1 file changed, 11 deletions(-)

diff --git a/fs/cifs/dfs_cache.c b/fs/cifs/dfs_cache.c
index b1fa30fefe1f..03c81c39a507 100644
--- a/fs/cifs/dfs_cache.c
+++ b/fs/cifs/dfs_cache.c
@@ -319,17 +319,6 @@ static inline unsigned int cache_entry_hash(const void *data, int size)
return h & (CACHE_HTABLE_SIZE - 1);
}

-/* Check whether second path component of @path is SYSVOL or NETLOGON */
-static inline bool is_sysvol_or_netlogon(const char *path)
-{
- const char *s;
- char sep = path[0];
-
- s = strchr(path + 1, sep) + 1;
- return !strncasecmp(s, "sysvol", strlen("sysvol")) ||
- !strncasecmp(s, "netlogon", strlen("netlogon"));
-}
-
/* Return target hint of a DFS cache entry */
static inline char *get_tgt_name(const struct cache_entry *ce)
{
--
2.17.1

2021-05-31 16:55:40

by Paulo Alcantara

Subject: Re: [PATCH -next] cifs: Remove unused inline function is_sysvol_or_netlogon()

YueHaibing <[email protected]> writes:

> is_sysvol_or_netlogon() is never used, so can remove it.
>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> fs/cifs/dfs_cache.c | 11 -----------
> 1 file changed, 11 deletions(-)

Reviewed-by: Paulo Alcantara (SUSE) <[email protected]>

2021-06-05 20:47:13

by Steve French

Subject: Re: [PATCH -next] cifs: Remove unused inline function is_sysvol_or_netlogon()

merged into cifs-2.6.git for-next

On Mon, May 31, 2021 at 9:50 AM Paulo Alcantara <[email protected]> wrote:
>
> YueHaibing <[email protected]> writes:
>
> > is_sysvol_or_netlogon() is never used, so can remove it.
> >
> > Signed-off-by: YueHaibing <[email protected]>
> > ---
> > fs/cifs/dfs_cache.c | 11 -----------
> > 1 file changed, 11 deletions(-)
>
> Reviewed-by: Paulo Alcantara (SUSE) <[email protected]>



--
Thanks,

Steve