2021-05-31 08:13:42

by Wesley Sheng

[permalink] [raw]
Subject: [PATCH] Documentation PCI: Fix typo in pci-error-recovery.rst

Replace "It" with "If", since it is a conditional statement.

Signed-off-by: Wesley Sheng <[email protected]>
---
Documentation/PCI/pci-error-recovery.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/PCI/pci-error-recovery.rst b/Documentation/PCI/pci-error-recovery.rst
index 84ceebb08cac..187f43a03200 100644
--- a/Documentation/PCI/pci-error-recovery.rst
+++ b/Documentation/PCI/pci-error-recovery.rst
@@ -295,7 +295,7 @@ and let the driver restart normal I/O processing.
A driver can still return a critical failure for this function if
it can't get the device operational after reset. If the platform
previously tried a soft reset, it might now try a hard reset (power
-cycle) and then call slot_reset() again. It the device still can't
+cycle) and then call slot_reset() again. If the device still can't
be recovered, there is nothing more that can be done; the platform
will typically report a "permanent failure" in such a case. The
device will be considered "dead" in this case.
--
2.25.1


2021-05-31 16:06:18

by Krzysztof Wilczyński

[permalink] [raw]
Subject: Re: [PATCH] Documentation PCI: Fix typo in pci-error-recovery.rst

Hi Wesley,

> Replace "It" with "If", since it is a conditional statement.
>
[...]

Nice catch!

> -cycle) and then call slot_reset() again. It the device still can't
> +cycle) and then call slot_reset() again. If the device still can't
[...]

Thank you!

Reviewed-by: Krzysztof Wilczyński <[email protected]>

Krzysztof

2021-06-01 16:12:31

by Bjorn Helgaas

[permalink] [raw]
Subject: Re: [PATCH] Documentation PCI: Fix typo in pci-error-recovery.rst

On Mon, May 31, 2021 at 04:12:15PM +0800, Wesley Sheng wrote:
> Replace "It" with "If", since it is a conditional statement.
>
> Signed-off-by: Wesley Sheng <[email protected]>

Applied to pci/error for v5.14 with Krzysztof's reviewed-by and
subject "Documentation: PCI: Fix typo in pci-error-recovery.rst" to
match previous convention, thanks!

> ---
> Documentation/PCI/pci-error-recovery.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/PCI/pci-error-recovery.rst b/Documentation/PCI/pci-error-recovery.rst
> index 84ceebb08cac..187f43a03200 100644
> --- a/Documentation/PCI/pci-error-recovery.rst
> +++ b/Documentation/PCI/pci-error-recovery.rst
> @@ -295,7 +295,7 @@ and let the driver restart normal I/O processing.
> A driver can still return a critical failure for this function if
> it can't get the device operational after reset. If the platform
> previously tried a soft reset, it might now try a hard reset (power
> -cycle) and then call slot_reset() again. It the device still can't
> +cycle) and then call slot_reset() again. If the device still can't
> be recovered, there is nothing more that can be done; the platform
> will typically report a "permanent failure" in such a case. The
> device will be considered "dead" in this case.
> --
> 2.25.1
>