2021-05-31 12:10:39

by Nobuhiro Iwamatsu

Subject: [PATCH] dt-bindings: gpio: zynq: convert bindings to YAML

Convert gpio for Xilinx Zynq SoC bindings documentation to YAML.

Signed-off-by: Nobuhiro Iwamatsu <[email protected]>
---
.../devicetree/bindings/gpio/gpio-zynq.txt | 36 -----------
.../devicetree/bindings/gpio/gpio-zynq.yaml | 59 +++++++++++++++++++
2 files changed, 59 insertions(+), 36 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/gpio/gpio-zynq.txt
create mode 100644 Documentation/devicetree/bindings/gpio/gpio-zynq.yaml

diff --git a/Documentation/devicetree/bindings/gpio/gpio-zynq.txt b/Documentation/devicetree/bindings/gpio/gpio-zynq.txt
deleted file mode 100644
index f693e82b4c0f1b..00000000000000
--- a/Documentation/devicetree/bindings/gpio/gpio-zynq.txt
+++ /dev/null
@@ -1,36 +0,0 @@
-Xilinx Zynq GPIO controller Device Tree Bindings
--------------------------------------------
-
-Required properties:
-- #gpio-cells : Should be two
- - First cell is the GPIO line number
- - Second cell is used to specify optional
- parameters (unused)
-- compatible : Should be "xlnx,zynq-gpio-1.0" or
- "xlnx,zynqmp-gpio-1.0" or "xlnx,versal-gpio-1.0
- or "xlnx,pmc-gpio-1.0
-- clocks : Clock specifier (see clock bindings for details)
-- gpio-controller : Marks the device node as a GPIO controller.
-- interrupts : Interrupt specifier (see interrupt bindings for
- details)
-- interrupt-controller : Marks the device node as an interrupt controller.
-- #interrupt-cells : Should be 2. The first cell is the GPIO number.
- The second cell bits[3:0] is used to specify trigger type and level flags:
- 1 = low-to-high edge triggered.
- 2 = high-to-low edge triggered.
- 4 = active high level-sensitive.
- 8 = active low level-sensitive.
-- reg : Address and length of the register set for the device
-
-Example:
- gpio@e000a000 {
- #gpio-cells = <2>;
- compatible = "xlnx,zynq-gpio-1.0";
- clocks = <&clkc 42>;
- gpio-controller;
- interrupt-parent = <&intc>;
- interrupts = <0 20 4>;
- interrupt-controller;
- #interrupt-cells = <2>;
- reg = <0xe000a000 0x1000>;
- };
diff --git a/Documentation/devicetree/bindings/gpio/gpio-zynq.yaml b/Documentation/devicetree/bindings/gpio/gpio-zynq.yaml
new file mode 100644
index 00000000000000..378da2649e668e
--- /dev/null
+++ b/Documentation/devicetree/bindings/gpio/gpio-zynq.yaml
@@ -0,0 +1,59 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/gpio/gpio-zynq.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Xilinx Zynq GPIO controller Device Tree Bindings
+
+maintainers:
+ - Michal Simek <[email protected]>
+
+properties:
+ compatible:
+ const: xlnx,zynq-gpio-1.0
+
+ reg:
+ maxItems: 1
+
+ "#gpio-cells":
+ const: 2
+
+ interrupts:
+ maxItems: 1
+
+ gpio-controller: true
+
+ interrupt-controller: true
+
+ "#interrupt-cells":
+ const: 2
+
+ clocks:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+ - "#gpio-cells"
+ - interrupts
+ - gpio-controller
+ - interrupt-controller
+ - "#interrupt-cells"
+ - clocks
+
+additionalProperties: false
+
+examples:
+ - |
+ gpio@e000a000 {
+ #gpio-cells = <2>;
+ compatible = "xlnx,zynq-gpio-1.0";
+ clocks = <&clkc 42>;
+ gpio-controller;
+ interrupt-parent = <&intc>;
+ interrupts = <0 20 4>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ reg = <0xe000a000 0x1000>;
+ };
--
2.30.0

2021-06-01 11:48:52

by Linus Walleij

Subject: Re: [PATCH] dt-bindings: gpio: zynq: convert bindings to YAML

On Mon, May 31, 2021 at 2:08 PM Nobuhiro Iwamatsu <[email protected]> wrote:

> Convert gpio for Xilinx Zynq SoC bindings documentation to YAML.
>
> Signed-off-by: Nobuhiro Iwamatsu <[email protected]>

Looks good to me!
Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij

2021-06-04 21:42:26

by Rob Herring

Subject: Re: [PATCH] dt-bindings: gpio: zynq: convert bindings to YAML

On Mon, 31 May 2021 21:07:53 +0900, Nobuhiro Iwamatsu wrote:
> Convert gpio for Xilinx Zynq SoC bindings documentation to YAML.
>
> Signed-off-by: Nobuhiro Iwamatsu <[email protected]>
> ---
> .../devicetree/bindings/gpio/gpio-zynq.txt | 36 -----------
> .../devicetree/bindings/gpio/gpio-zynq.yaml | 59 +++++++++++++++++++
> 2 files changed, 59 insertions(+), 36 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/gpio/gpio-zynq.txt
> create mode 100644 Documentation/devicetree/bindings/gpio/gpio-zynq.yaml
>

Reviewed-by: Rob Herring <[email protected]>

2021-06-21 10:31:26

by Bartosz Golaszewski

Subject: Re: [PATCH] dt-bindings: gpio: zynq: convert bindings to YAML

On Mon, May 31, 2021 at 2:08 PM Nobuhiro Iwamatsu <[email protected]> wrote:
>
> Convert gpio for Xilinx Zynq SoC bindings documentation to YAML.
>
> Signed-off-by: Nobuhiro Iwamatsu <[email protected]>
> ---

Applied, thanks!

Bart