2021-05-28 20:04:24

by Gustavo A. R. Silva

Subject: [PATCH][next] kgdb: Fix fall-through warning for Clang

In preparation to enable -Wimplicit-fallthrough for Clang, fix a
fall-through warning by explicitly adding a goto statement instead
of letting the code fall through to the next case.

Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
JFYI: We had thousands of these sorts of warnings and now we are down
to just 25 in linux-next. This is one of those last remaining
warnings.

kernel/debug/debug_core.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/kernel/debug/debug_core.c b/kernel/debug/debug_core.c
index 4708aec492df..431749dd9ab6 100644
--- a/kernel/debug/debug_core.c
+++ b/kernel/debug/debug_core.c
@@ -1038,6 +1038,7 @@ dbg_notify_reboot(struct notifier_block *this, unsigned long code, void *x)
switch (kgdbreboot) {
case 1:
kgdb_breakpoint();
+ goto done;
case -1:
goto done;
}
--
2.27.0

2021-06-01 19:23:44

by Kees Cook

Subject: Re: [PATCH][next] kgdb: Fix fall-through warning for Clang

On Fri, May 28, 2021 at 03:02:22PM -0500, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a
> fall-through warning by explicitly adding a goto statement instead
> of letting the code fall through to the next case.
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <[email protected]>
> ---
> JFYI: We had thousands of these sorts of warnings and now we are down
> to just 25 in linux-next. This is one of those last remaining
> warnings.

So close! :)

Reviewed-by: Kees Cook <[email protected]>

-Kees

>
> kernel/debug/debug_core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/debug/debug_core.c b/kernel/debug/debug_core.c
> index 4708aec492df..431749dd9ab6 100644
> --- a/kernel/debug/debug_core.c
> +++ b/kernel/debug/debug_core.c
> @@ -1038,6 +1038,7 @@ dbg_notify_reboot(struct notifier_block *this, unsigned long code, void *x)
> switch (kgdbreboot) {
> case 1:
> kgdb_breakpoint();
> + goto done;
> case -1:
> goto done;
> }
> --
> 2.27.0
>

--
Kees Cook

2021-06-01 22:14:38

by Gustavo A. R. Silva

Subject: Re: [PATCH][next] kgdb: Fix fall-through warning for Clang

On 6/1/21 14:20, Kees Cook wrote:
> On Fri, May 28, 2021 at 03:02:22PM -0500, Gustavo A. R. Silva wrote:
>> In preparation to enable -Wimplicit-fallthrough for Clang, fix a
>> fall-through warning by explicitly adding a goto statement instead
>> of letting the code fall through to the next case.
>>
>> Link: https://github.com/KSPP/linux/issues/115
>> Signed-off-by: Gustavo A. R. Silva <[email protected]>
>> ---
>> JFYI: We had thousands of these sorts of warnings and now we are down
>> to just 25 in linux-next. This is one of those last remaining
>> warnings.
>
> So close! :)

Almost there!

> Reviewed-by: Kees Cook <[email protected]>

Thanks

--
Gustavo

>
> -Kees
>
>>
>> kernel/debug/debug_core.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/kernel/debug/debug_core.c b/kernel/debug/debug_core.c
>> index 4708aec492df..431749dd9ab6 100644
>> --- a/kernel/debug/debug_core.c
>> +++ b/kernel/debug/debug_core.c
>> @@ -1038,6 +1038,7 @@ dbg_notify_reboot(struct notifier_block *this, unsigned long code, void *x)
>> switch (kgdbreboot) {
>> case 1:
>> kgdb_breakpoint();
>> + goto done;
>> case -1:
>> goto done;
>> }
>> --
>> 2.27.0
>>
>

2021-06-17 10:21:40

by Daniel Thompson

Subject: Re: [PATCH][next] kgdb: Fix fall-through warning for Clang

On Fri, May 28, 2021 at 03:02:22PM -0500, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a
> fall-through warning by explicitly adding a goto statement instead
> of letting the code fall through to the next case.
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <[email protected]>

Applied, thanks.


> ---
> JFYI: We had thousands of these sorts of warnings and now we are down
> to just 25 in linux-next. This is one of those last remaining
> warnings.
>
> kernel/debug/debug_core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/debug/debug_core.c b/kernel/debug/debug_core.c
> index 4708aec492df..431749dd9ab6 100644
> --- a/kernel/debug/debug_core.c
> +++ b/kernel/debug/debug_core.c
> @@ -1038,6 +1038,7 @@ dbg_notify_reboot(struct notifier_block *this, unsigned long code, void *x)
> switch (kgdbreboot) {
> case 1:
> kgdb_breakpoint();
> + goto done;
> case -1:
> goto done;
> }
> --
> 2.27.0