2021-06-03 13:29:36

by Siddharth Chandrasekaran

Subject: [PATCH] KVM: hyper-v: housekeeping: Remove unnecessary type cast

Remove unnecessary type cast of 'u8 instructions[]' to
'unsigned char *'.

Signed-off-by: Siddharth Chandrasekaran <[email protected]>
---
arch/x86/kvm/hyperv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kvm/hyperv.c b/arch/x86/kvm/hyperv.c
index f00830e5202f..7d9eb13174b6 100644
--- a/arch/x86/kvm/hyperv.c
+++ b/arch/x86/kvm/hyperv.c
@@ -1252,7 +1252,7 @@ static int kvm_hv_set_msr_pw(struct kvm_vcpu *vcpu, u32 msr, u64 data,
i += 3;

/* ret */
- ((unsigned char *)instructions)[i++] = 0xc3;
+ instructions[i++] = 0xc3;

addr = data & HV_X64_MSR_HYPERCALL_PAGE_ADDRESS_MASK;
if (kvm_vcpu_write_guest(vcpu, addr, instructions, i))
--
2.17.1




Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879

2021-06-15 14:54:20

by Sean Christopherson

Subject: Re: [PATCH] KVM: hyper-v: housekeeping: Remove unnecessary type cast

On Thu, Jun 03, 2021, Siddharth Chandrasekaran wrote:
> Remove unnecessary type cast of 'u8 instructions[]' to
> 'unsigned char *'.
>
> Signed-off-by: Siddharth Chandrasekaran <[email protected]>
> ---

Reviewed-by: Sean Christopherson <[email protected]>