2021-06-03 16:50:53

by Srinivas Neeli

Subject: [PATCH] gpio: gpio-xilinx: update on suspend and resume calls

Current AXI GPIO driver checking for interrupt data in suspend and
resume path and reporting as error in case of no interrupt connection.
As per AXI GPIO IP specification interrupt connection is optional,
driver logic is updated in suspend and resume calls by reporting
debug message and enable/disable clock in case of no connection.

Signed-off-by: Srinivas Neeli <[email protected]>
---
drivers/gpio/gpio-xilinx.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
index b411d3156e0b..e0681c37f1cb 100644
--- a/drivers/gpio/gpio-xilinx.c
+++ b/drivers/gpio/gpio-xilinx.c
@@ -302,8 +302,8 @@ static int __maybe_unused xgpio_suspend(struct device *dev)
struct irq_data *data = irq_get_irq_data(gpio->irq);

if (!data) {
- dev_err(dev, "irq_get_irq_data() failed\n");
- return -EINVAL;
+ dev_dbg(dev, "IRQ not connected\n");
+ return pm_runtime_force_suspend(dev);
}

if (!irqd_is_wakeup_set(data))
@@ -348,8 +348,8 @@ static int __maybe_unused xgpio_resume(struct device *dev)
struct irq_data *data = irq_get_irq_data(gpio->irq);

if (!data) {
- dev_err(dev, "irq_get_irq_data() failed\n");
- return -EINVAL;
+ dev_dbg(dev, "IRQ not connected\n");
+ return pm_runtime_force_resume(dev);
}

if (!irqd_is_wakeup_set(data))
--
2.22.0

2021-06-14 20:18:20

by Bartosz Golaszewski

Subject: Re: [PATCH] gpio: gpio-xilinx: update on suspend and resume calls

On Thu, Jun 3, 2021 at 6:49 PM Srinivas Neeli <[email protected]> wrote:
>
> Current AXI GPIO driver checking for interrupt data in suspend and
> resume path and reporting as error in case of no interrupt connection.
> As per AXI GPIO IP specification interrupt connection is optional,
> driver logic is updated in suspend and resume calls by reporting
> debug message and enable/disable clock in case of no connection.
>
> Signed-off-by: Srinivas Neeli <[email protected]>
> ---

Applied, thanks!

Bart