The allwinner,sun6i-a31-hwspinlock.yaml binding has a mismatched
$id and fails to compile the example due to undefined args specifier
values for clocks and resets. Fix both of these issues.
Fixes: f9e784dcb63f ("dt-bindings: hwlock: add sun6i_hwspinlock")
Signed-off-by: Suman Anna <[email protected]>
---
Hi Wilken,
This fixes the warnings for now on linux-next, but I think the example
should be including sun6i-a31-ccu.h files instead to be accurate, and
those files are missing the definitions for CLK_BUS_SPINLOCK and
RST_BUS_SPINLOCK. Feel free to send a newer version or do an incremental
patch on top.
regards
Suman
.../bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml
index 733c3d01e56c..10e5a53e447b 100644
--- a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml
+++ b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
%YAML 1.2
---
-$id: http://devicetree.org/schemas/hwlock/allwinner,sun6i-hwspinlock.yaml#
+$id: http://devicetree.org/schemas/hwlock/allwinner,sun6i-a31-hwspinlock.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#
title: SUN6I hardware spinlock driver for Allwinner sun6i compatible SoCs
@@ -36,6 +36,9 @@ additionalProperties: false
examples:
- |
+ #include <dt-bindings/clock/sun8i-a23-a33-ccu.h>
+ #include <dt-bindings/reset/sun8i-a23-a33-ccu.h>
+
hwlock@1c18000 {
compatible = "allwinner,sun6i-a31-hwspinlock";
reg = <0x01c18000 0x1000>;
--
2.30.1
On Thu, 3 Jun 2021 09:42:16 -0500
Suman Anna <[email protected]> wrote:
> The allwinner,sun6i-a31-hwspinlock.yaml binding has a mismatched
> $id and fails to compile the example due to undefined args specifier
> values for clocks and resets. Fix both of these issues.
>
> Fixes: f9e784dcb63f ("dt-bindings: hwlock: add sun6i_hwspinlock")
> Signed-off-by: Suman Anna <[email protected]>
> ---
> Hi Wilken,
>
> This fixes the warnings for now on linux-next, but I think the example
> should be including sun6i-a31-ccu.h files instead to be accurate, and
> those files are missing the definitions for CLK_BUS_SPINLOCK and
> RST_BUS_SPINLOCK. Feel free to send a newer version or do an incremental
> patch on top.
>
> regards
> Suman
Hi Suman,
thank you for fixing this. I would have fix it the same way for now, so it is
fine for me. But I will keep an eye on it.
greetings,
Will
> .../bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml
> b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml index
> 733c3d01e56c..10e5a53e447b 100644 ---
> a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml +++
> b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
> %YAML 1.2
> ---
> -$id: http://devicetree.org/schemas/hwlock/allwinner,sun6i-hwspinlock.yaml#
> +$id: http://devicetree.org/schemas/hwlock/allwinner,sun6i-a31-hwspinlock.yaml#
> $schema: http://devicetree.org/meta-schemas/core.yaml#
>
> title: SUN6I hardware spinlock driver for Allwinner sun6i compatible SoCs
> @@ -36,6 +36,9 @@ additionalProperties: false
>
> examples:
> - |
> + #include <dt-bindings/clock/sun8i-a23-a33-ccu.h>
> + #include <dt-bindings/reset/sun8i-a23-a33-ccu.h>
> +
> hwlock@1c18000 {
> compatible = "allwinner,sun6i-a31-hwspinlock";
> reg = <0x01c18000 0x1000>;
On 6/3/21 11:55 PM, Wilken Gottwalt wrote:
> On Thu, 3 Jun 2021 09:42:16 -0500
> Suman Anna <[email protected]> wrote:
>
>> The allwinner,sun6i-a31-hwspinlock.yaml binding has a mismatched
>> $id and fails to compile the example due to undefined args specifier
>> values for clocks and resets. Fix both of these issues.
>>
>> Fixes: f9e784dcb63f ("dt-bindings: hwlock: add sun6i_hwspinlock")
>> Signed-off-by: Suman Anna <[email protected]>
>> ---
>> Hi Wilken,
>>
>> This fixes the warnings for now on linux-next, but I think the example
>> should be including sun6i-a31-ccu.h files instead to be accurate, and
>> those files are missing the definitions for CLK_BUS_SPINLOCK and
>> RST_BUS_SPINLOCK. Feel free to send a newer version or do an incremental
>> patch on top.
>>
>> regards
>> Suman
>
> Hi Suman,
>
> thank you for fixing this. I would have fix it the same way for now, so it is
> fine for me. But I will keep an eye on it.
Thanks Will.
Bjorn,
Do ignore the RFC tag then, and you can pick up the patch.
regards
Suman
>
> greetings,
> Will
>
>> .../bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml
>> b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml index
>> 733c3d01e56c..10e5a53e447b 100644 ---
>> a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml +++
>> b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml @@ -1,7 +1,7 @@
>> # SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
>> %YAML 1.2
>> ---
>> -$id: http://devicetree.org/schemas/hwlock/allwinner,sun6i-hwspinlock.yaml#
>> +$id: http://devicetree.org/schemas/hwlock/allwinner,sun6i-a31-hwspinlock.yaml#
>> $schema: http://devicetree.org/meta-schemas/core.yaml#
>>
>> title: SUN6I hardware spinlock driver for Allwinner sun6i compatible SoCs
>> @@ -36,6 +36,9 @@ additionalProperties: false
>>
>> examples:
>> - |
>> + #include <dt-bindings/clock/sun8i-a23-a33-ccu.h>
>> + #include <dt-bindings/reset/sun8i-a23-a33-ccu.h>
>> +
>> hwlock@1c18000 {
>> compatible = "allwinner,sun6i-a31-hwspinlock";
>> reg = <0x01c18000 0x1000>;
>
On Thu, Jun 3, 2021 at 9:42 AM Suman Anna <[email protected]> wrote:
>
> The allwinner,sun6i-a31-hwspinlock.yaml binding has a mismatched
> $id and fails to compile the example due to undefined args specifier
> values for clocks and resets. Fix both of these issues.
>
> Fixes: f9e784dcb63f ("dt-bindings: hwlock: add sun6i_hwspinlock")
> Signed-off-by: Suman Anna <[email protected]>
> ---
> Hi Wilken,
>
> This fixes the warnings for now on linux-next, but I think the example
> should be including sun6i-a31-ccu.h files instead to be accurate, and
> those files are missing the definitions for CLK_BUS_SPINLOCK and
> RST_BUS_SPINLOCK. Feel free to send a newer version or do an incremental
> patch on top.
>
> regards
> Suman
>
> .../bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
Acked-by: Rob Herring <[email protected]>
Hi Bjorn,
On 6/7/21 8:19 AM, Rob Herring wrote:
> On Thu, Jun 3, 2021 at 9:42 AM Suman Anna <[email protected]> wrote:
>>
>> The allwinner,sun6i-a31-hwspinlock.yaml binding has a mismatched
>> $id and fails to compile the example due to undefined args specifier
>> values for clocks and resets. Fix both of these issues.
>>
>> Fixes: f9e784dcb63f ("dt-bindings: hwlock: add sun6i_hwspinlock")
>> Signed-off-by: Suman Anna <[email protected]>
>> ---
>> Hi Wilken,
>>
>> This fixes the warnings for now on linux-next, but I think the example
>> should be including sun6i-a31-ccu.h files instead to be accurate, and
>> those files are missing the definitions for CLK_BUS_SPINLOCK and
>> RST_BUS_SPINLOCK. Feel free to send a newer version or do an incremental
>> patch on top.
>>
>> regards
>> Suman
>>
>> .../bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> Acked-by: Rob Herring <[email protected]>
>
Gentle ping, can you pick up this patch and the remoteproc pas binding
indentations fixes please so that linux-next is sane w.r.t these?
regards
Suman
On Mon 14 Jun 14:15 CDT 2021, Suman Anna wrote:
> Hi Bjorn,
>
> On 6/7/21 8:19 AM, Rob Herring wrote:
> > On Thu, Jun 3, 2021 at 9:42 AM Suman Anna <[email protected]> wrote:
> >>
> >> The allwinner,sun6i-a31-hwspinlock.yaml binding has a mismatched
> >> $id and fails to compile the example due to undefined args specifier
> >> values for clocks and resets. Fix both of these issues.
> >>
> >> Fixes: f9e784dcb63f ("dt-bindings: hwlock: add sun6i_hwspinlock")
> >> Signed-off-by: Suman Anna <[email protected]>
> >> ---
> >> Hi Wilken,
> >>
> >> This fixes the warnings for now on linux-next, but I think the example
> >> should be including sun6i-a31-ccu.h files instead to be accurate, and
> >> those files are missing the definitions for CLK_BUS_SPINLOCK and
> >> RST_BUS_SPINLOCK. Feel free to send a newer version or do an incremental
> >> patch on top.
> >>
> >> regards
> >> Suman
> >>
> >> .../bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml | 5 ++++-
> >> 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > Acked-by: Rob Herring <[email protected]>
> >
>
> Gentle ping, can you pick up this patch and the remoteproc pas binding
> indentations fixes please so that linux-next is sane w.r.t these?
>
Sorry, I picked up some (biological) bug and haven't been of much use
the last couple of weeks. I've picked the two patches now, thank you
Suman!
Regards,
Bjorn