2021-06-04 11:40:35

by Íñigo Huguet

Subject: [PATCH] net:cxgb3: fix incorrect work cancellation

In my last changes in commit 5e0b8928927f I introduced a copy-paste bug,
leading to cancel twice qresume_task work for OFLD queue, and never the
one for CTRL queue. This patch cancels correctly both works.

Signed-off-by: Íñigo Huguet <[email protected]>
---
drivers/net/ethernet/chelsio/cxgb3/sge.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/chelsio/cxgb3/sge.c b/drivers/net/ethernet/chelsio/cxgb3/sge.c
index fa91aa57b50a..d1dfccdf571d 100644
--- a/drivers/net/ethernet/chelsio/cxgb3/sge.c
+++ b/drivers/net/ethernet/chelsio/cxgb3/sge.c
@@ -3310,7 +3310,7 @@ void t3_sge_stop(struct adapter *adap)
struct sge_qset *qs = &adap->sge.qs[i];

cancel_work_sync(&qs->txq[TXQ_OFLD].qresume_task);
- cancel_work_sync(&qs->txq[TXQ_OFLD].qresume_task);
+ cancel_work_sync(&qs->txq[TXQ_CTRL].qresume_task);
}
}

--
2.31.1

2021-06-04 21:52:57

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] net:cxgb3: fix incorrect work cancellation

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Fri, 4 Jun 2021 13:36:33 +0200 you wrote:
> In my last changes in commit 5e0b8928927f I introduced a copy-paste bug,
> leading to cancel twice qresume_task work for OFLD queue, and never the
> one for CTRL queue. This patch cancels correctly both works.
>
> Signed-off-by: Íñigo Huguet <[email protected]>
> ---
> drivers/net/ethernet/chelsio/cxgb3/sge.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- net:cxgb3: fix incorrect work cancellation
https://git.kernel.org/netdev/net-next/c/d5a73dcf0901

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html