2021-06-05 03:25:52

by Jiabing Wan

[permalink] [raw]
Subject: [PATCH] drm/i915/display: remove duplicated argument

Fix the following coccicheck warning:

./drivers/gpu/drm/i915/display/intel_display_power.c:3081:1-28:
duplicated argument to & or |

This commit fixes duplicate argument. It might be a typo.
But what I can do is to remove it now.

Signed-off-by: Wan Jiabing <[email protected]>
---
drivers/gpu/drm/i915/display/intel_display_power.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
index 3e1f6ec61514..4298ae684d7d 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.c
+++ b/drivers/gpu/drm/i915/display/intel_display_power.c
@@ -3078,7 +3078,6 @@ intel_display_power_put_mask_in_set(struct drm_i915_private *i915,
BIT_ULL(POWER_DOMAIN_PORT_DDI_C_LANES) | \
BIT_ULL(POWER_DOMAIN_PORT_DDI_LANES_D_XELPD) | \
BIT_ULL(POWER_DOMAIN_PORT_DDI_LANES_E_XELPD) | \
- BIT_ULL(POWER_DOMAIN_AUX_C) | \
BIT_ULL(POWER_DOMAIN_PORT_DDI_LANES_TC1) | \
BIT_ULL(POWER_DOMAIN_PORT_DDI_LANES_TC2) | \
BIT_ULL(POWER_DOMAIN_PORT_DDI_LANES_TC3) | \
--
2.20.1


2021-06-07 12:18:55

by Imre Deak

[permalink] [raw]
Subject: Re: [PATCH] drm/i915/display: remove duplicated argument

On Sat, Jun 05, 2021 at 11:22:07AM +0800, Wan Jiabing wrote:
> Fix the following coccicheck warning:
>
> ./drivers/gpu/drm/i915/display/intel_display_power.c:3081:1-28:
> duplicated argument to & or |
>
> This commit fixes duplicate argument. It might be a typo.
> But what I can do is to remove it now.
>
> Signed-off-by: Wan Jiabing <[email protected]>

Thanks, pushed to drm-intel-next.

> ---
> drivers/gpu/drm/i915/display/intel_display_power.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
> index 3e1f6ec61514..4298ae684d7d 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_power.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_power.c
> @@ -3078,7 +3078,6 @@ intel_display_power_put_mask_in_set(struct drm_i915_private *i915,
> BIT_ULL(POWER_DOMAIN_PORT_DDI_C_LANES) | \
> BIT_ULL(POWER_DOMAIN_PORT_DDI_LANES_D_XELPD) | \
> BIT_ULL(POWER_DOMAIN_PORT_DDI_LANES_E_XELPD) | \
> - BIT_ULL(POWER_DOMAIN_AUX_C) | \
> BIT_ULL(POWER_DOMAIN_PORT_DDI_LANES_TC1) | \
> BIT_ULL(POWER_DOMAIN_PORT_DDI_LANES_TC2) | \
> BIT_ULL(POWER_DOMAIN_PORT_DDI_LANES_TC3) | \
> --
> 2.20.1
>