2021-06-07 04:56:22

by Jiabing Wan

Subject: [PATCH] [-next] cifsd: remove duplicated argument

Fix the following coccicheck warning:
./fs/cifsd/smb2pdu.c:1713:27-41: duplicated argument to & or |

FILE_DELETE_LE is duplicated. Remove one and reorder argument to
make coding style reasonable.

Signed-off-by: Wan Jiabing <[email protected]>
---
fs/cifsd/smb2pdu.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/fs/cifsd/smb2pdu.c b/fs/cifsd/smb2pdu.c
index 3e112fbdc2d9..9a46897d39c9 100644
--- a/fs/cifsd/smb2pdu.c
+++ b/fs/cifsd/smb2pdu.c
@@ -1710,10 +1710,10 @@ int smb2_tree_connect(struct ksmbd_work *work)
KSMBD_TREE_CONN_FLAG_WRITABLE)) {
rsp->MaximalAccess |= FILE_WRITE_DATA_LE |
FILE_APPEND_DATA_LE | FILE_WRITE_EA_LE |
- FILE_DELETE_CHILD_LE | FILE_DELETE_LE |
- FILE_WRITE_ATTRIBUTES_LE | FILE_DELETE_LE |
- FILE_READ_CONTROL_LE | FILE_WRITE_DAC_LE |
- FILE_WRITE_OWNER_LE | FILE_SYNCHRONIZE_LE;
+ FILE_DELETE_LE | FILE_WRITE_ATTRIBUTES_LE |
+ FILE_DELETE_CHILD_LE | FILE_READ_CONTROL_LE |
+ FILE_WRITE_DAC_LE | FILE_WRITE_OWNER_LE |
+ FILE_SYNCHRONIZE_LE;
}
}

--
2.20.1

2021-06-07 05:48:28

by Namjae Jeon

Subject: RE: [PATCH] [-next] cifsd: remove duplicated argument

> Fix the following coccicheck warning:
> ./fs/cifsd/smb2pdu.c:1713:27-41: duplicated argument to & or |
>
> FILE_DELETE_LE is duplicated. Remove one and reorder argument to make coding style reasonable.
>
> Signed-off-by: Wan Jiabing <[email protected]>
I will apply it, Thanks for your patch!