2021-06-07 06:27:05

by ChenXiaoSong

Subject: [PATCH -next] apparmor: fix doc warning

Fix gcc W=1 warning:

security/apparmor/apparmorfs.c:2125: warning: Function parameter or member 'p' not described in '__next_profile'

Signed-off-by: ChenXiaoSong <[email protected]>
---
security/apparmor/apparmorfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/apparmor/apparmorfs.c b/security/apparmor/apparmorfs.c
index 5bb9b9910aee..4720b8b9239c 100644
--- a/security/apparmor/apparmorfs.c
+++ b/security/apparmor/apparmorfs.c
@@ -2114,7 +2114,7 @@ static struct aa_profile *__first_profile(struct aa_ns *root,

/**
* __next_profile - step to the next profile in a profile tree
- * @profile: current profile in tree (NOT NULL)
+ * @p: current profile in tree (NOT NULL)
*
* Perform a depth first traversal on the profile tree in a namespace
*
--
2.25.4

2021-06-08 06:29:57

by John Johansen

Subject: Re: [PATCH -next] apparmor: fix doc warning

On 6/6/21 11:30 PM, ChenXiaoSong wrote:
> Fix gcc W=1 warning:
>
> security/apparmor/apparmorfs.c:2125: warning: Function parameter or member 'p' not described in '__next_profile'
>
> Signed-off-by: ChenXiaoSong <[email protected]>

Thanks I have pulled this into my tree

> ---
> security/apparmor/apparmorfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/apparmor/apparmorfs.c b/security/apparmor/apparmorfs.c
> index 5bb9b9910aee..4720b8b9239c 100644
> --- a/security/apparmor/apparmorfs.c
> +++ b/security/apparmor/apparmorfs.c
> @@ -2114,7 +2114,7 @@ static struct aa_profile *__first_profile(struct aa_ns *root,
>
> /**
> * __next_profile - step to the next profile in a profile tree
> - * @profile: current profile in tree (NOT NULL)
> + * @p: current profile in tree (NOT NULL)
> *
> * Perform a depth first traversal on the profile tree in a namespace
> *
>