2021-06-08 00:56:57

by Maciej Żenczykowski

Subject: [PATCH] f_ncm: ncm_bitrate (speed) is unsigned

From: Maciej Żenczykowski <[email protected]>

[ 190.544755] configfs-gadget gadget: notify speed -44967296

This is because 4250000000 - 2**32 is -44967296.

Cc: Brooke Basile <[email protected]>
Cc: Bryan O'Donoghue <[email protected]>
Cc: Felipe Balbi <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Lorenzo Colitti <[email protected]>
Cc: Yauheni Kaliuta <[email protected]>
Cc: Linux USB Mailing List <[email protected]>
Fixes: 9f6ce4240a2b ("usb: gadget: f_ncm.c added")
Signed-off-by: Maciej Żenczykowski <[email protected]>
---
drivers/usb/gadget/function/f_ncm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/function/f_ncm.c b/drivers/usb/gadget/function/f_ncm.c
index 019bea8e09cc..0d23c6c11a13 100644
--- a/drivers/usb/gadget/function/f_ncm.c
+++ b/drivers/usb/gadget/function/f_ncm.c
@@ -583,7 +583,7 @@ static void ncm_do_notify(struct f_ncm *ncm)
data[0] = cpu_to_le32(ncm_bitrate(cdev->gadget));
data[1] = data[0];

- DBG(cdev, "notify speed %d\n", ncm_bitrate(cdev->gadget));
+ DBG(cdev, "notify speed %u\n", ncm_bitrate(cdev->gadget));
ncm->notify_state = NCM_NOTIFY_CONNECT;
break;
}
--
2.32.0.rc1.229.g3e70b5a671-goog

2021-06-08 01:46:45

by Lorenzo Colitti

Subject: Re: [PATCH] f_ncm: ncm_bitrate (speed) is unsigned

On Tue, Jun 8, 2021 at 9:53 AM Maciej Żenczykowski
<[email protected]> wrote:
> --- a/drivers/usb/gadget/function/f_ncm.c
> +++ b/drivers/usb/gadget/function/f_ncm.c
> @@ -583,7 +583,7 @@ static void ncm_do_notify(struct f_ncm *ncm)
> data[0] = cpu_to_le32(ncm_bitrate(cdev->gadget));
> data[1] = data[0];
>
> - DBG(cdev, "notify speed %d\n", ncm_bitrate(cdev->gadget));
> + DBG(cdev, "notify speed %u\n", ncm_bitrate(cdev->gadget));
> ncm->notify_state = NCM_NOTIFY_CONNECT;
> break;
> }

Acked-By: Lorenzo Colitti <[email protected]>