2021-06-09 02:21:43

by Matthias Brugger

Subject: [PATCH] pinctrl: mediatek: fix mode encoding

From: Matthias Brugger <[email protected]>

Pin modes are encoded in the SoC data structure. Use that value to set
IES SMT.

Cc: Fabien Parent <[email protected]>
Cc: Sean Wang <[email protected]>
Cc: Mattijs Korpershoek <[email protected]>
Cc: [email protected]
Fixes: 696beef77521 ("pinctrl: mediatek: move bit assignment")
Signed-off-by: Matthias Brugger <[email protected]>

Signed-off-by: Matthias Brugger <[email protected]>
---

drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
index 525b1aa7f7a6..5f7c421ab6e7 100644
--- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
+++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
@@ -134,13 +134,13 @@ static int mtk_pconf_set_ies_smt(struct mtk_pinctrl *pctl, unsigned pin,
pin, pctl->devdata->port_align, value, arg);
}

- bit = BIT(pin & 0xf);
-
if (arg == PIN_CONFIG_INPUT_ENABLE)
offset = pctl->devdata->ies_offset;
else
offset = pctl->devdata->smt_offset;

+ bit = BIT(offset & pctl->devdata->mode_mask);
+
if (value)
reg_addr = SET_ADDR(mtk_get_port(pctl, pin) + offset, pctl);
else
--
2.31.1

2021-06-09 14:39:53

by Linus Walleij

Subject: Re: [PATCH] pinctrl: mediatek: fix mode encoding

On Tue, Jun 8, 2021 at 5:07 PM <[email protected]> wrote:

> From: Matthias Brugger <[email protected]>
>
> Pin modes are encoded in the SoC data structure. Use that value to set
> IES SMT.
>
> Cc: Fabien Parent <[email protected]>
> Cc: Sean Wang <[email protected]>
> Cc: Mattijs Korpershoek <[email protected]>
> Cc: [email protected]
> Fixes: 696beef77521 ("pinctrl: mediatek: move bit assignment")
> Signed-off-by: Matthias Brugger <[email protected]>
> Signed-off-by: Matthias Brugger <[email protected]>

Patch applied!

Yours,
Linus Walleij