2021-06-09 12:18:20

by William Breathitt Gray

Subject: [PATCH v11 03/33] counter: 104-quad-8: Remove pointless comment

It is obvious that devm_counter_register() is used to register a Counter
device, so a comment stating such is pointless here.

Acked-by: Syed Nayyar Waris <[email protected]>
Signed-off-by: William Breathitt Gray <[email protected]>
---
drivers/counter/104-quad-8.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/counter/104-quad-8.c b/drivers/counter/104-quad-8.c
index 9691f8612be8..4bb9abffae48 100644
--- a/drivers/counter/104-quad-8.c
+++ b/drivers/counter/104-quad-8.c
@@ -1082,7 +1082,6 @@ static int quad8_probe(struct device *dev, unsigned int id)
/* Enable all counters */
outb(QUAD8_CHAN_OP_ENABLE_COUNTERS, base[id] + QUAD8_REG_CHAN_OP);

- /* Register Counter device */
return devm_counter_register(dev, &priv->counter);
}

--
2.32.0

2021-06-09 17:56:14

by Jonathan Cameron

Subject: Re: [PATCH v11 03/33] counter: 104-quad-8: Remove pointless comment

On Wed, 9 Jun 2021 10:31:06 +0900
William Breathitt Gray <[email protected]> wrote:

> It is obvious that devm_counter_register() is used to register a Counter
> device, so a comment stating such is pointless here.
>
> Acked-by: Syed Nayyar Waris <[email protected]>
> Signed-off-by: William Breathitt Gray <[email protected]>
Applied.
> ---
> drivers/counter/104-quad-8.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/counter/104-quad-8.c b/drivers/counter/104-quad-8.c
> index 9691f8612be8..4bb9abffae48 100644
> --- a/drivers/counter/104-quad-8.c
> +++ b/drivers/counter/104-quad-8.c
> @@ -1082,7 +1082,6 @@ static int quad8_probe(struct device *dev, unsigned int id)
> /* Enable all counters */
> outb(QUAD8_CHAN_OP_ENABLE_COUNTERS, base[id] + QUAD8_REG_CHAN_OP);
>
> - /* Register Counter device */
> return devm_counter_register(dev, &priv->counter);
> }
>