2021-06-10 06:14:09

by lijian_8010a29

[permalink] [raw]
Subject: [PATCH v2] scsi: lpfc: lpfc_init: deleted these repeated words

From: lijian <[email protected]>

deleted these repeated words 'the', 'using' and 'be' in the comments.

Signed-off-by: lijian <[email protected]>
---
v2: Fix these typos
Change 'irrelvant' to 'irrelevant'.
Change 'will be re-try' to 'will be retried'.

drivers/scsi/lpfc/lpfc_init.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
index 932c6bdb8c40..bba1ecdfa501 100644
--- a/drivers/scsi/lpfc/lpfc_init.c
+++ b/drivers/scsi/lpfc/lpfc_init.c
@@ -5094,7 +5094,7 @@ lpfc_sli4_async_link_evt(struct lpfc_hba *phba,
bf_set(lpfc_mbx_read_top_link_spd, la,
(bf_get(lpfc_acqe_link_speed, acqe_link)));

- /* Fake the following irrelvant fields */
+ /* Fake the following irrelevant fields */
bf_set(lpfc_mbx_read_top_topology, la, LPFC_TOPOLOGY_PT_PT);
bf_set(lpfc_mbx_read_top_alpa_granted, la, 0);
bf_set(lpfc_mbx_read_top_il, la, 0);
@@ -5894,7 +5894,7 @@ lpfc_sli4_async_fip_evt(struct lpfc_hba *phba,
phba->fcf.fcf_flag &= ~FCF_ACVL_DISC;
spin_unlock_irq(&phba->hbalock);
/*
- * Last resort will be re-try on
+ * Last resort will be retried on
* the current registered FCF entry.
*/
lpfc_retry_pport_discovery(phba);
--
2.25.1


2021-06-10 06:21:29

by Joe Perches

[permalink] [raw]
Subject: Re: [PATCH v2] scsi: lpfc: lpfc_init: deleted these repeated words

On Thu, 2021-06-10 at 14:09 +0800, [email protected] wrote:
> From: lijian <[email protected]>
>
> deleted these repeated words 'the', 'using' and 'be' in the comments.
>
> Signed-off-by: lijian <[email protected]>
> ---
> v2: Fix these typos
> Change 'irrelvant' to 'irrelevant'.
> Change 'will be re-try' to 'will be retried'.

This should be part of the commit message.
The content below the --- line is not added to any git commit.

> diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
[]
> @@ -5894,7 +5894,7 @@ lpfc_sli4_async_fip_evt(struct lpfc_hba *phba,
> ? phba->fcf.fcf_flag &= ~FCF_ACVL_DISC;
> ? spin_unlock_irq(&phba->hbalock);
> ? /*
> - * Last resort will be re-try on
> + * Last resort will be retried on

retried on the current/to retry (with?) the current

Your spelling fixes seem reasonable but perhaps you could find a
fully fluent English speaker/writer to review your proposals before
submitting English grammar patches.