2021-06-11 01:35:05

by Tong Tiangen

[permalink] [raw]
Subject: [PATCH -next v2] usb: isp1760: Fix meaningless check in isp1763_run()

Remove attribution to retval before check, which make it completely
meaningless, and does't check what it was supposed: the return
value of the timed function to set up configuration flag.

Fixes: 60d789f3bfbb ("usb: isp1760: add support for isp1763")
Signed-off-by: Tong Tiangen <[email protected]>
Tested-by: Rui Miguel Silva <[email protected]>
Reviewed-by: Rui Miguel Silva <[email protected]>
---
drivers/usb/isp1760/isp1760-hcd.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/isp1760/isp1760-hcd.c b/drivers/usb/isp1760/isp1760-hcd.c
index 016a54ea76f4..27168b4a4ef2 100644
--- a/drivers/usb/isp1760/isp1760-hcd.c
+++ b/drivers/usb/isp1760/isp1760-hcd.c
@@ -1648,7 +1648,6 @@ static int isp1763_run(struct usb_hcd *hcd)
down_write(&ehci_cf_port_reset_rwsem);
retval = isp1760_hcd_set_and_wait(hcd, FLAG_CF, 250 * 1000);
up_write(&ehci_cf_port_reset_rwsem);
- retval = 0;
if (retval)
return retval;

--
2.18.0.huawei.25