2021-06-11 08:38:31

by Srinivas Kandagatla

Subject: [PATCH 0/9] nvmem: patches (set 1) for 5.14

Hi Greg,

Here are some nvmem patches for 5.14 which includes
- these are mostly minor fixes in provider drivers like missing
MODULE_DEVICE_TABLE and improve comments
- fix in core for missing of_node_put.
- setting correct provider type in sunxi sid provider

thanks for you help,
srini

Bixuan Cui (1):
nvmem: sprd: Add missing MODULE_DEVICE_TABLE

Christophe JAILLET (2):
nvmem: sprd: Fix an error message
nvmem: core: add a missing of_node_put

Douglas Anderson (2):
nvmem: core: constify nvmem_cell_read_variable_common() return value
nvmem: qfprom: Improve the comment about regulator setting

Rajendra Nayak (1):
nvmem: qfprom: minor nit fixes

Samuel Holland (1):
nvmem: sunxi_sid: Set type to OTP

Srinivas Kandagatla (1):
nvmem: qcom-spmi-sdam: add missing MODULE_DEVICE_TABLE

Zou Wei (1):
nvmem: sc27xx: Add missing MODULE_DEVICE_TABLE

drivers/nvmem/core.c | 19 +++++++++++--------
drivers/nvmem/qcom-spmi-sdam.c | 1 +
drivers/nvmem/qfprom.c | 9 +++++----
drivers/nvmem/sc27xx-efuse.c | 1 +
drivers/nvmem/sprd-efuse.c | 3 ++-
drivers/nvmem/sunxi_sid.c | 1 +
6 files changed, 21 insertions(+), 13 deletions(-)

--
2.21.0

2021-06-11 08:40:04

by Srinivas Kandagatla

Subject: [PATCH 8/9] nvmem: core: constify nvmem_cell_read_variable_common() return value

From: Douglas Anderson <[email protected]>

The caller doesn't modify the memory pointed to by the pointer so it
can be const.

Suggested-by: Stephen Boyd <[email protected]>
Signed-off-by: Douglas Anderson <[email protected]>
Reviewed-by: Stephen Boyd <[email protected]>
Signed-off-by: Srinivas Kandagatla <[email protected]>
---
drivers/nvmem/core.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
index f9c9c9859919..4868aa876e1b 100644
--- a/drivers/nvmem/core.c
+++ b/drivers/nvmem/core.c
@@ -1609,9 +1609,9 @@ int nvmem_cell_read_u64(struct device *dev, const char *cell_id, u64 *val)
}
EXPORT_SYMBOL_GPL(nvmem_cell_read_u64);

-static void *nvmem_cell_read_variable_common(struct device *dev,
- const char *cell_id,
- size_t max_len, size_t *len)
+static const void *nvmem_cell_read_variable_common(struct device *dev,
+ const char *cell_id,
+ size_t max_len, size_t *len)
{
struct nvmem_cell *cell;
int nbits;
@@ -1655,7 +1655,7 @@ int nvmem_cell_read_variable_le_u32(struct device *dev, const char *cell_id,
u32 *val)
{
size_t len;
- u8 *buf;
+ const u8 *buf;
int i;

buf = nvmem_cell_read_variable_common(dev, cell_id, sizeof(*val), &len);
@@ -1686,7 +1686,7 @@ int nvmem_cell_read_variable_le_u64(struct device *dev, const char *cell_id,
u64 *val)
{
size_t len;
- u8 *buf;
+ const u8 *buf;
int i;

buf = nvmem_cell_read_variable_common(dev, cell_id, sizeof(*val), &len);
--
2.21.0

2021-06-11 09:00:52

by Greg Kroah-Hartman

Subject: Re: [PATCH 0/9] nvmem: patches (set 1) for 5.14

On Fri, Jun 11, 2021 at 09:33:39AM +0100, Srinivas Kandagatla wrote:
> Hi Greg,
>
> Here are some nvmem patches for 5.14 which includes
> - these are mostly minor fixes in provider drivers like missing
> MODULE_DEVICE_TABLE and improve comments
> - fix in core for missing of_node_put.
> - setting correct provider type in sunxi sid provider

I took the last 4 patches of this series. See the review comments on
the first 5 for what should be done with them.

thanks,

greg k-h